fix: make HEX_CHARS_RE case-insensitive for ETH address validation#173
Open
fazalpsinfo-cmyk wants to merge 1 commit into
Open
fix: make HEX_CHARS_RE case-insensitive for ETH address validation#173fazalpsinfo-cmyk wants to merge 1 commit into
fazalpsinfo-cmyk wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #163
is_valid_eth_addresscallsuses_only_hash_charswhich uses a case-sensitive hex regex. Ethereum addresses like0x5aAeb6053F3E94C9b9A09f33669435E7Ef1BeAedfail validation because of mixed case.Fix: add
re.IGNORECASEtoHEX_CHARS_RE.If you find this useful, consider supporting my work: https://buymeacoffee.com/muhamedfazalps