fix(ci): sink release fires on server tags and breaks on slashed refs#12
Merged
Conversation
Two bugs, both hit by the server/v0.1.6 release:
1. `release: published` fires for EVERY release in this repo. Every release
in its history is `server/v*`, which has nothing to do with the sink — so
the sink build ran on a server release. Guard on `sink/v*`.
2. Tags carry a slash (`sink/v0.1.0`), and ref_name was interpolated straight
into a filename, so the shell read everything before the slash as a
directory:
cp ... beyond-pg-sink-server/v0.1.6-linux-amd64
cp: cannot create regular file '...': No such file or directory
Use the bare version (${GITHUB_REF_NAME##*/}) for asset names; address the
release by its full tag.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
server/v0.1.6release failed the sink workflow:Two independent bugs:
1. It should never have run.
on: release: types: [published]fires for every release. Every release in this repo's history isserver/v*— nothing to do with the sink. Now guarded onsink/v*.2. Slashed tags break the filename.
github.ref_nameisserver/v0.1.6, interpolated straight into acpdestination — so the shell readsbeyond-pg-sink-server/as a directory that doesn't exist. Asset names now use the bare version (${GITHUB_REF_NAME##*/}); the release is still addressed by its full tag. This would have broken a genuinesink/v*release too.Unrelated to #11.
🤖 Generated with Claude Code