chore(release): make promote_rc workflow call publish_release workflow to finish publishing#3900
Conversation
The tagging done by promote_rc doesn't trigger the on-tag trigger of the publish workflow. To fix this, promote_rc now outputs the promoted version, and release_promote_rc.yaml uses it to call release_publish.yaml explicitly.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for writing the promoted release candidate version to the GITHUB_OUTPUT environment variable in promote_rc.py, along with corresponding unit tests. The review feedback suggests specifying encoding="utf-8" when writing and reading files to ensure cross-platform compatibility, and refactoring the unit tests to manage the temporary directory locally within the specific test rather than in the global setUp method.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
rickeylev
changed the title
1 participant
Why: The tagging done by promote_rc doesn't trigger the on-tag trigger of the publish workflow (due to GITHUB_TOKEN restriction).
How: