tools: Build docker image cloudstack-simulator#13597
Conversation
weizhouapache
changed the title
There was a problem hiding this comment.
Pull request overview
This PR updates the CloudStack simulator Docker image build to modernize the base OS/toolchain and address build breakages when building the image in CI.
Changes:
- Upgrade base image to Ubuntu 24.04 and Java to OpenJDK 17.
- Upgrade Node.js installation to Node 24 (NodeSource setup script).
- Make Marvin tarball detection case-insensitive and simplify related build steps.
- Trigger the Docker image workflow on an additional branch.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tools/docker/Dockerfile | Updates OS/toolchain versions and tweaks Marvin + Node install steps for the simulator image build. |
| .github/workflows/docker-cloudstack-simulator.yml | Adds docker-image-build as an additional push branch trigger for the image build workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13597 +/- ##
=========================================
Coverage 19.50% 19.50%
- Complexity 19438 19441 +3
=========================================
Files 6303 6303
Lines 569288 569288
Branches 69792 69792
=========================================
Hits 111028 111028
- Misses 446106 446108 +2
+ Partials 12154 12152 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
| - docker-image-build | ||
| tags: | ||
| - 4.* | ||
| - 5.* |
🔴 Test Coverage Grade:
|
| Metric | Value |
|---|---|
| Line coverage | 24.31% |
| Branch coverage | 18.44% |
Grade Scale
| Grade | Line Coverage | Meaning |
|---|---|---|
| 🟢 A | ≥ 80% | Excellent - this code sleeps well at night 😴 |
| 🟡 B | 60-79% | Good - almost there, don't stop now 😉 |
| 🟠 C | 40-59% | Acceptable - your code is wearing a seatbelt, but no airbags 😬 |
| 🔴 D | 20-39% | Marginal - boldly shipping where no test has gone before 🖖 |
| ⛔ F | < 20% | Failing - tests? what tests? 🔥 |
Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run
weizhouapache
force-pushed
the
docker-image-build
branch
from
8a20246 to
8ef4579
Compare
| environment=NODE_OPTIONS="--openssl-legacy-provider" | ||
| command=/bin/bash -c "NODE_OPTIONS=--openssl-legacy-provider npm run serve" |
| MARVIN_FILE=`find /root/tools/marvin/dist/ -name "[mM]arvin*.tar.gz"`; \ | ||
| pip3 install $MARVIN_FILE --break-system-packages |
| push: | ||
| branches: | ||
| - main | ||
| - docker-image-build |
|
@weizhouapache, just out of curiosity, is the UI being built and executed correctly with Node.js 24? |
|
🔴 Test Coverage Grade:
|
| Metric | Value |
|---|---|
| Line coverage | 24.31% |
| Branch coverage | 18.44% |
Grade Scale
| Grade | Line Coverage | Meaning |
|---|---|---|
| 🟢 A | ≥ 80% | Excellent - this code sleeps well at night 😴 |
| 🟡 B | 60-79% | Good - almost there, don't stop now 😉 |
| 🟠 C | 40-59% | Acceptable - your code is wearing a seatbelt, but no airbags 😬 |
| 🔴 D | 20-39% | Marginal - boldly shipping where no test has gone before 🖖 |
| ⛔ F | < 20% | Failing - tests? what tests? 🔥 |
Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run
Yes @bernardodemarco You can have a try with the last image : |
Description
This PR fixes docker image build errors
ubuntu 24.04instead of ubunutu 22.04Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?