Skip to content

Fix GCP IO tests on Java 21#39295

Merged
tvalentyn merged 1 commit into
apache:masterfrom
bvolpato:bvolpato/fix-gcp-java21-precommit
Jul 13, 2026
Merged

Fix GCP IO tests on Java 21#39295
tvalentyn merged 1 commit into
apache:masterfrom
bvolpato:bvolpato/fix-gcp-java21-precommit

Conversation

@bvolpato

Copy link
Copy Markdown
Contributor

Fixes #39267.

Java 21 GCP IO precommit tests fail for two independent reasons:

  • BeamRowToStorageApiProtoTest initializes microsecond logical types from wall-clock values that can contain nanosecond precision.
  • Apache Arrow direct-memory access requires the java.nio package to be open.

This change uses fixed, microsecond-aligned values for affected logical types and opens java.nio for GCP IO test tasks, matching Beam's Arrow module configuration.

Validation:

  • Java 21 full GCP IO unit suite and Spotless check
  • Java 21 targeted Beam row and Arrow regression tests
  • Java 17 targeted Beam row and Arrow regression tests
  • GCP IO test Checkstyle

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • CHANGES.md update not needed for a test-only fix.
  • Apache Individual Contributor License Agreement not needed for this small contribution.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses compatibility issues preventing GCP IO tests from passing on Java 21. By ensuring consistent time precision in logical types and configuring the necessary JVM access for memory operations, the changes stabilize the test suite across newer Java versions.

Highlights

  • JVM Configuration: Updated the GCP IO build configuration to open the java.nio package, enabling Apache Arrow direct memory access on Java 17 and later.
  • Test Stability: Refactored BeamRowToStorageApiProtoTest to use fixed, microsecond-aligned time values, preventing precision-related failures during tests on Java 21.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request configures JVM arguments for test tasks in the Google Cloud Platform IO build file to open java.nio for Apache Arrow direct memory access under Java 17+. Additionally, it updates BeamRowToStorageApiProtoTest to use static constants instead of dynamic time values for test fields, improving test determinism. There are no review comments, so no feedback is provided.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @chamikaramj for label java.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@tvalentyn tvalentyn merged commit 23e2398 into apache:master Jul 13, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The PreCommit Java GCP IO Direct job is flaky

2 participants