Ethtool Queue Enhancement

[sunnyhe2]

Summary

• added queue fields
• ethtool -S no longer depends on rdma
• rdma collector args changed for html output

Test plan

• pytest test/unit
• pytest test/functional (if applicable)
• pre-commit run --all-files

Checklist

• Added/updated tests (or explained why not)
• Updated docs/README if behavior changed
• No secrets or credentials committed

[alexandraBara]

this should also populate statistics right. Something like:

+        raw_statistics = {k: v for k, v in stats_dict.items() if k != "netdev"}
+
         return EthtoolStatistics(
             netdev=netdev,
             driver=driver or None,
             vendor_statistics=vendor_stats,
+            statistics=raw_statistics,
             queue_statistics=queue_statistics,
         )

[sunnyhe2]

We could, but the current implementation only keeps what we check into the datamodel and drops the rest. I think we are okay to omit this as the raw output still exists in command_artifacts.json/html

[alexandraBara]

what about this:

node-scraper/nodescraper/plugins/inband/network/network_analyzer.py

Line 73 in 94e8691

for stat_name, stat_value in ethtool_info.statistics.items():