feat: show macro key assignments on the macro page#3002
Conversation
|
This PR contains the commits of other PR. As far as I see the UI part of the other PR is havent fully decided so this PR also blocked. |
List where each macro is used with links back to the assigned key, and avoid treating Jump to macro navigation as a config change. Co-authored-by: Cursor <cursoragent@cursor.com>
30b72b3 to
91de325
Compare
|
Rebased onto The diff is 17 files / +344 −35, scoped to issue #2743 only. |
|
I summarise here my problem with this PR and macro grouping
I am not agains ai development but somehow have to improve their skills to decrease the cost of afterwork. Or we don't do after work and we will see the outcome after few months. I especially like I don't have to fight with pixels but I don't like the mess and noise that generating. |
Move macro assignment finding out of uhk-common, compute Used on view models in the smart macro-edit container, prefer Bootstrap utilities over custom CSS, and add Cursor rules capturing the review guidance. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Addressed the architectural points from the review:
|
Co-authored-by: Cursor <cursoragent@cursor.com>
| combineLatest([ | ||
| store.select(getSelectedMacro), | ||
| store.select(getKeymaps), | ||
| store.select(getDefaultUserConfiguration), |
There was a problem hiding this comment.
We load the default configuration into the store when opening the Add Keymap menu.
I do it to save some memory because it is not frequently used feature. We could load it and app start and refresh when new device is connected, but I haven't did it, because little bit confusing me to see the macro assigned on a non qwerty keymap and we so the qwerty key name.
For example I assign the macro to the Dvorak O that is Qwerty S and I see Dvorak for PC -> Base -> S instead of Dvorak for PC -> Base -> O
The macro page "Used on" links need the default QWERTY keymap, which was previously only loaded when opening the add-keymap page. Co-authored-by: Cursor <cursoragent@cursor.com>
Resolves #2743
Summary
keymap ⭢ layer ⭢ keyusing default QWERTY labels)./keymap/{abbreviation}?layer=&module=&key=and open the key action popover.Test plan
Back to [name] keymap.Made with Cursor