feat: esm only, remove source maps and src, skills direct to dist for…#6427
Conversation
|
View your CI Pipeline Execution ↗ for commit 18fc625
☁️ Nx Cloud last updated this comment at |
📝 WalkthroughWalkthroughThe changes align package publication with ESM-only distribution artifacts, disable generated sourcemaps, update declaration rewriting, remove published source directories, and revise repository skill guidance to inspect installed ChangesArtifact alignment
Estimated code review effort: 3 (Moderate) | ~25 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
🧹 Nitpick comments (1)
packages/angular-table/package.json (1)
57-57: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winUse
rimraffor cross-platform compatibility.The
findcommand is specific to Unix-like systems and may fail in Windows environments (unless running in WSL or a bash-like terminal). Sincerimrafis already used in this command, consider using it to delete the.mapfiles as well.♻️ Proposed fix
- "build": "ng-packagr -p ng-package.json -c tsconfig.build.json && rimraf ./dist/package.json && find dist -name '*.map' -delete", + "build": "ng-packagr -p ng-package.json -c tsconfig.build.json && rimraf ./dist/package.json && rimraf \"dist/**/*.map\"",🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/angular-table/package.json` at line 57, Update the package.json build script to replace the Unix-specific find command with rimraf-based deletion of generated .map files, preserving the existing cleanup of dist/package.json and the build flow.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/angular-table/skills/with-tanstack-query/SKILL.md`:
- Line 142: Update the inspection guidance near the relevant Angular Query
reference to explicitly use the published declarations path
node_modules/@tanstack/angular-query-experimental/dist/types/ instead of generic
Angular Query source, while preserving the existing `@tanstack/angular-table` and
core feature inspection guidance.
In `@packages/react-table/skills/migrate-v8-to-v9/SKILL.md`:
- Line 226: Use package-qualified declaration paths in both instructions: update
packages/react-table/skills/migrate-v8-to-v9/SKILL.md lines 226-226 to reference
node_modules/@tanstack/react-table/dist/legacy.d.ts, and update
packages/react-table/skills/table-state/SKILL.md lines 255-255 to reference
node_modules/@tanstack/react-table/dist/Subscribe.d.ts.
In `@packages/react-table/skills/with-tanstack-query/SKILL.md`:
- Line 186: Update the inspection guidance in the TanStack Query skill to
replace the vague “relevant core feature source” reference with the
corresponding installed node_modules/@tanstack/table-core/dist/*.d.ts feature
declaration, or explicitly name a repository-only source path if that is
intended. Keep the existing react-table dist and react-query source inspection
guidance unchanged.
In `@packages/solid-table/skills/with-tanstack-query/SKILL.md`:
- Line 149: Complete the installed-artifact discovery migration at
packages/solid-table/skills/with-tanstack-query/SKILL.md:149-149 by replacing
the vague Solid Query source reference with the exact installed dist
declarations or feature-output path. Also update
packages/svelte-table/skills/getting-started/SKILL.md:172-172 to replace “the
exported implementation” with the exact installed dist file or directory.
In `@packages/table-core/skills/column-resizing/SKILL.md`:
- Line 91: Make every discovery path explicit and relative to installed
packages: in packages/table-core/skills/column-resizing/SKILL.md:91 replace the
vague sizing feature directory with
node_modules/@tanstack/table-core/dist/features/column-sizing/; in
packages/angular-table/skills/getting-started/SKILL.md:138 prefix the table-core
feature path with node_modules/; in
packages/angular-table/skills/table-state/SKILL.md:197 prefix
`@tanstack/angular-store/dist/` with node_modules/, make reactivity.d.ts
package-relative, and use the exact node_modules/@tanstack/table-core/dist
feature path; in packages/table-core/skills/global-filtering/SKILL.md:84 replace
dist/features/column-filtering/ with
node_modules/@tanstack/table-core/dist/features/column-filtering/.
---
Nitpick comments:
In `@packages/angular-table/package.json`:
- Line 57: Update the package.json build script to replace the Unix-specific
find command with rimraf-based deletion of generated .map files, preserving the
existing cleanup of dist/package.json and the build flow.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 4e4ba561-bb05-42e5-a544-f31f17da8ad7
📒 Files selected for processing (113)
_artifacts/domain_map.yaml_artifacts/skill_spec.md_artifacts/skill_tree.yamlpackages/alpine-table/package.jsonpackages/alpine-table/skills/create-table-hook/SKILL.mdpackages/alpine-table/skills/getting-started/SKILL.mdpackages/alpine-table/skills/table-state/SKILL.mdpackages/alpine-table/tsdown.config.tspackages/angular-table-devtools/package.jsonpackages/angular-table-devtools/skills/devtools/SKILL.mdpackages/angular-table-devtools/tsdown.config.tspackages/angular-table/package.jsonpackages/angular-table/skills/create-table-hook/SKILL.mdpackages/angular-table/skills/getting-started/SKILL.mdpackages/angular-table/skills/migrate-v8-to-v9/SKILL.mdpackages/angular-table/skills/table-state/SKILL.mdpackages/angular-table/skills/with-tanstack-query/SKILL.mdpackages/angular-table/skills/with-tanstack-virtual/SKILL.mdpackages/angular-table/tsconfig.build.jsonpackages/ember-table/package.jsonpackages/ember-table/rollup.config.mjspackages/ember-table/skills/create-table-hook/SKILL.mdpackages/ember-table/skills/getting-started/SKILL.mdpackages/ember-table/skills/table-state/SKILL.mdpackages/lit-table/package.jsonpackages/lit-table/skills/create-table-hook/SKILL.mdpackages/lit-table/skills/getting-started/SKILL.mdpackages/lit-table/skills/migrate-v8-to-v9/SKILL.mdpackages/lit-table/skills/table-state/SKILL.mdpackages/lit-table/skills/with-tanstack-virtual/SKILL.mdpackages/lit-table/tsdown.config.tspackages/match-sorter-utils/package.jsonpackages/match-sorter-utils/skills/fuzzy-ranking/SKILL.mdpackages/match-sorter-utils/tsdown.config.tspackages/preact-table-devtools/package.jsonpackages/preact-table-devtools/skills/devtools/SKILL.mdpackages/preact-table-devtools/tsdown.config.tspackages/preact-table/package.jsonpackages/preact-table/skills/create-table-hook/SKILL.mdpackages/preact-table/skills/getting-started/SKILL.mdpackages/preact-table/skills/migrate-v8-to-v9/SKILL.mdpackages/preact-table/skills/table-state/SKILL.mdpackages/preact-table/skills/with-tanstack-query/SKILL.mdpackages/preact-table/skills/with-tanstack-virtual/SKILL.mdpackages/preact-table/tsdown.config.tspackages/react-table-devtools/package.jsonpackages/react-table-devtools/skills/devtools/SKILL.mdpackages/react-table-devtools/tsdown.config.tspackages/react-table/package.jsonpackages/react-table/skills/create-table-hook/SKILL.mdpackages/react-table/skills/getting-started/SKILL.mdpackages/react-table/skills/migrate-v8-to-v9/SKILL.mdpackages/react-table/skills/table-state/SKILL.mdpackages/react-table/skills/with-tanstack-query/SKILL.mdpackages/react-table/skills/with-tanstack-virtual/SKILL.mdpackages/react-table/tsdown.config.tspackages/solid-table-devtools/package.jsonpackages/solid-table-devtools/skills/devtools/SKILL.mdpackages/solid-table-devtools/tsdown.config.tspackages/solid-table/package.jsonpackages/solid-table/skills/create-table-hook/SKILL.mdpackages/solid-table/skills/getting-started/SKILL.mdpackages/solid-table/skills/migrate-v8-to-v9/SKILL.mdpackages/solid-table/skills/table-state/SKILL.mdpackages/solid-table/skills/with-tanstack-query/SKILL.mdpackages/solid-table/skills/with-tanstack-virtual/SKILL.mdpackages/solid-table/tsdown.config.tspackages/svelte-table/package.jsonpackages/svelte-table/skills/create-table-hook/SKILL.mdpackages/svelte-table/skills/getting-started/SKILL.mdpackages/svelte-table/skills/migrate-v8-to-v9/SKILL.mdpackages/svelte-table/skills/table-state/SKILL.mdpackages/svelte-table/skills/with-tanstack-query/SKILL.mdpackages/svelte-table/skills/with-tanstack-virtual/SKILL.mdpackages/table-core/package.jsonpackages/table-core/skills/aggregation/SKILL.mdpackages/table-core/skills/api-not-found/SKILL.mdpackages/table-core/skills/client-vs-server/SKILL.mdpackages/table-core/skills/column-faceting/SKILL.mdpackages/table-core/skills/column-filtering/SKILL.mdpackages/table-core/skills/column-ordering/SKILL.mdpackages/table-core/skills/column-pinning/SKILL.mdpackages/table-core/skills/column-resizing/SKILL.mdpackages/table-core/skills/column-sizing/SKILL.mdpackages/table-core/skills/column-visibility/SKILL.mdpackages/table-core/skills/core/SKILL.mdpackages/table-core/skills/custom-features/SKILL.mdpackages/table-core/skills/expanding/SKILL.mdpackages/table-core/skills/global-filtering/SKILL.mdpackages/table-core/skills/grouping/SKILL.mdpackages/table-core/skills/migrate-v8-to-v9/SKILL.mdpackages/table-core/skills/pagination/SKILL.mdpackages/table-core/skills/row-pinning/SKILL.mdpackages/table-core/skills/row-selection/SKILL.mdpackages/table-core/skills/sorting/SKILL.mdpackages/table-core/skills/table-features/SKILL.mdpackages/table-core/skills/typescript/SKILL.mdpackages/table-core/tsdown.config.tspackages/table-devtools/package.jsonpackages/table-devtools/skills/devtools/SKILL.mdpackages/table-devtools/tsdown.config.tspackages/vue-table-devtools/package.jsonpackages/vue-table-devtools/skills/devtools/SKILL.mdpackages/vue-table-devtools/tsdown.config.tspackages/vue-table/package.jsonpackages/vue-table/skills/create-table-hook/SKILL.mdpackages/vue-table/skills/getting-started/SKILL.mdpackages/vue-table/skills/migrate-v8-to-v9/SKILL.mdpackages/vue-table/skills/table-state/SKILL.mdpackages/vue-table/skills/with-tanstack-query/SKILL.mdpackages/vue-table/skills/with-tanstack-virtual/SKILL.mdpackages/vue-table/tsdown.config.tsscripts/rewrite-table-core-dts.mjs
💤 Files with no reviewable changes (3)
- packages/ember-table/package.json
- packages/angular-table-devtools/package.json
- packages/svelte-table/package.json
| ## API Discovery | ||
|
|
||
| Inspect installed `@tanstack/angular-table/src/injectTable.ts`, the relevant core feature source, and installed Angular Query source for the exact `injectQuery` package/version contract. | ||
| Inspect installed `@tanstack/angular-table/dist/types/`, the relevant core feature source, and installed Angular Query source for the exact `injectQuery` package/version contract. |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Locate the file and inspect the relevant section.
git ls-files 'packages/angular-table/skills/with-tanstack-query/SKILL.md'
echo '--- SKILL excerpt ---'
nl -ba packages/angular-table/skills/with-tanstack-query/SKILL.md | sed -n '130,155p'
echo '--- package root candidates ---'
fd -a 'angular-query|tanstack-query|query' packages -t d -I || true
fd -a 'package.json' . -t f -I | sed -n '1,120p' || trueRepository: TanStack/table
Length of output: 273
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo '--- SKILL excerpt ---'
awk 'NR>=130 && NR<=155 {printf "%4d %s\n", NR, $0}' packages/angular-table/skills/with-tanstack-query/SKILL.md
echo '--- package and file candidates ---'
fd -a 'package.json' . -t f -I | sed -n '1,200p'
echo '--- angular-query / tanstack-query mentions ---'
rg -n --hidden --glob '!**/node_modules/**' --glob '!**/.git/**' 'installed Angular Query source|injectQuery|`@tanstack/angular-table`|angular-query' packages . | sed -n '1,200p'Repository: TanStack/table
Length of output: 32441
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo '--- angular query package candidates ---'
fd -a 'angular-query-experimental|angular-query' packages -t d -I
echo '--- package.json files for angular query packages ---'
fd -a 'package.json' packages -t f -I | rg 'angular-query|query-experimental|angular-table' || true
echo '--- package.json content if present ---'
for f in $(fd -a 'package.json' packages -t f -I | rg 'angular-query|query-experimental' || true); do
echo "### $f"
awk 'NR<=220 {printf "%4d %s\n", NR, $0}' "$f"
done
echo '--- imports / references to angular-query-experimental ---'
rg -n --hidden --glob '!**/node_modules/**' --glob '!**/.git/**' '`@tanstack/angular-query-experimental`|injectQuery' packages docs | sed -n '1,220p'Repository: TanStack/table
Length of output: 2051
🌐 Web query:
@tanstack/angular-query-experimental published package dist types exports injectQuery package layout
💡 Result:
The @tanstack/angular-query-experimental package is the official Angular adapter for TanStack Query [1][2]. As of July 17, 2026, it remains in an experimental stage, meaning that breaking changes can occur in both minor and patch releases [1][3]. Users are advised to lock their version to a specific patch level if using it in production to prevent unexpected issues [1][4]. Key aspects of the package layout and functionality include: Package Usage and Installation: The package is installed via npm, pnpm, yarn, or bun (e.g., npm i @tanstack/angular-query-experimental) [1][3][2]. It requires Angular 16 or higher [1][3]. Core Functions and Exports: The library exposes several key functions and types for managing asynchronous data, most notably injectQuery, which allows for reactive data fetching within Angular components and services [1][2][5]. Key exports include: - Functions: injectQuery, injectMutation, provideTanStackQuery, and provideQueryClient, among others [6][7]. - Type Aliases: Various options and result types such as InjectQueryOptions, CreateQueryOptions, and CreateQueryResult [6][7][8]. Functionality: - Integration: TanStack Query is initialized using the provideTanStackQuery provider, typically in the application's bootstrap configuration [1][4][9]. - injectQuery: This function is the primary way to subscribe to queries. It accepts a factory function that returns query options and supports dynamic updates if options are provided as signals [1][2][8]. - Injection Context: injectQuery requires an injection context (via inject) by default, but also accepts an optional Injector via InjectQueryOptions if needed [8][10]. Documentation: Comprehensive API references and guides are available on the official TanStack Query website, detailing the various available functions, type aliases, and configuration options [11][6][5][10].
Citations:
- 1: https://npmjs.com/package/@tanstack/angular-query-experimental
- 2: https://github.com/TanStack/query/tree/main/packages/angular-query-experimental
- 3: https://tanstack.dev/query/latest/docs/framework/angular/installation
- 4: https://tanstack.com/query/latest/docs/framework/angular/quick-start
- 5: https://tanstack.com/query/v5/docs/framework/angular/guides/queries
- 6: https://tanstack.com/query/v5/docs/framework/angular/reference/index
- 7: https://github.com/TanStack/query/blob/feb1efd8/packages/angular-query-experimental/src/index.ts
- 8: https://github.com/TanStack/query/blob/feb1efd8/packages/angular-query-experimental/src/inject-query.ts
- 9: https://tanstack.com/query/latest/docs/framework/angular/reference/functions/provideTanStackQuery
- 10: https://tanstack-query-44.mintlify.app/api/angular/inject-query
- 11: https://tanstack.com/query/latest/docs/framework/angular/reference/index
Use the published Angular Query declarations path.
Line 142 should point to node_modules/@tanstack/angular-query-experimental/dist/types/ instead of generic “Angular Query source”; the contract belongs in published artifacts, not unpublished src files.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/angular-table/skills/with-tanstack-query/SKILL.md` at line 142,
Update the inspection guidance near the relevant Angular Query reference to
explicitly use the published declarations path
node_modules/@tanstack/angular-query-experimental/dist/types/ instead of generic
Angular Query source, while preserving the existing `@tanstack/angular-table` and
core feature inspection guidance.
| ## API discovery | ||
|
|
||
| Inspect `node_modules/@tanstack/react-table/src/index.ts` and `node_modules/@tanstack/table-core/src/index.ts` for the installed v9 exports and types. Inspect `src/legacy.ts` only to identify temporary bridge code that remains to be removed. | ||
| Inspect `node_modules/@tanstack/react-table/dist/index.d.ts` and `node_modules/@tanstack/table-core/dist/index.d.ts` for the installed v9 exports and types. Inspect `dist/legacy.d.ts` only to identify temporary bridge code that remains to be removed. |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Use package-qualified paths for every installed declaration.
Both instructions mix explicit node_modules paths with incomplete relative filenames, which can send users to the wrong location.
packages/react-table/skills/migrate-v8-to-v9/SKILL.md#L226-L226: usenode_modules/@tanstack/react-table/dist/legacy.d.ts.packages/react-table/skills/table-state/SKILL.md#L255-L255: usenode_modules/@tanstack/react-table/dist/Subscribe.d.ts.
🧰 Tools
🪛 SkillSpector (2.3.11)
[warning] 57: [MP2] Context Window Stuffing: Skill attempts to fill the context window with filler content, displacing legitimate instructions and safety constraints. This can degrade agent performance or bypass safety boundaries.
Remediation: Implement context-window management that detects and rejects padding or stuffing attempts. Prioritize system instructions over user-injected content.
(Memory Poisoning (MP2))
[warning] 57: [MP2] Context Window Stuffing: Skill attempts to fill the context window with filler content, displacing legitimate instructions and safety constraints. This can degrade agent performance or bypass safety boundaries.
Remediation: Implement context-window management that detects and rejects padding or stuffing attempts. Prioritize system instructions over user-injected content.
(Memory Poisoning (MP2))
[warning] 81: [MP2] Context Window Stuffing: Skill attempts to fill the context window with filler content, displacing legitimate instructions and safety constraints. This can degrade agent performance or bypass safety boundaries.
Remediation: Implement context-window management that detects and rejects padding or stuffing attempts. Prioritize system instructions over user-injected content.
(Memory Poisoning (MP2))
[warning] 83: [MP2] Context Window Stuffing: Skill attempts to fill the context window with filler content, displacing legitimate instructions and safety constraints. This can degrade agent performance or bypass safety boundaries.
Remediation: Implement context-window management that detects and rejects padding or stuffing attempts. Prioritize system instructions over user-injected content.
(Memory Poisoning (MP2))
[warning] 84: [MP2] Context Window Stuffing: Skill attempts to fill the context window with filler content, displacing legitimate instructions and safety constraints. This can degrade agent performance or bypass safety boundaries.
Remediation: Implement context-window management that detects and rejects padding or stuffing attempts. Prioritize system instructions over user-injected content.
(Memory Poisoning (MP2))
[warning] 86: [MP2] Context Window Stuffing: Skill attempts to fill the context window with filler content, displacing legitimate instructions and safety constraints. This can degrade agent performance or bypass safety boundaries.
Remediation: Implement context-window management that detects and rejects padding or stuffing attempts. Prioritize system instructions over user-injected content.
(Memory Poisoning (MP2))
[warning] 122: [MP2] Context Window Stuffing: Skill attempts to fill the context window with filler content, displacing legitimate instructions and safety constraints. This can degrade agent performance or bypass safety boundaries.
Remediation: Implement context-window management that detects and rejects padding or stuffing attempts. Prioritize system instructions over user-injected content.
(Memory Poisoning (MP2))
[warning] 122: [MP2] Context Window Stuffing: Skill attempts to fill the context window with filler content, displacing legitimate instructions and safety constraints. This can degrade agent performance or bypass safety boundaries.
Remediation: Implement context-window management that detects and rejects padding or stuffing attempts. Prioritize system instructions over user-injected content.
(Memory Poisoning (MP2))
[warning] 124: [MP2] Context Window Stuffing: Skill attempts to fill the context window with filler content, displacing legitimate instructions and safety constraints. This can degrade agent performance or bypass safety boundaries.
Remediation: Implement context-window management that detects and rejects padding or stuffing attempts. Prioritize system instructions over user-injected content.
(Memory Poisoning (MP2))
[warning] 125: [MP2] Context Window Stuffing: Skill attempts to fill the context window with filler content, displacing legitimate instructions and safety constraints. This can degrade agent performance or bypass safety boundaries.
Remediation: Implement context-window management that detects and rejects padding or stuffing attempts. Prioritize system instructions over user-injected content.
(Memory Poisoning (MP2))
[warning] 126: [MP2] Context Window Stuffing: Skill attempts to fill the context window with filler content, displacing legitimate instructions and safety constraints. This can degrade agent performance or bypass safety boundaries.
Remediation: Implement context-window management that detects and rejects padding or stuffing attempts. Prioritize system instructions over user-injected content.
(Memory Poisoning (MP2))
[warning] 126: [MP2] Context Window Stuffing: Skill attempts to fill the context window with filler content, displacing legitimate instructions and safety constraints. This can degrade agent performance or bypass safety boundaries.
Remediation: Implement context-window management that detects and rejects padding or stuffing attempts. Prioritize system instructions over user-injected content.
(Memory Poisoning (MP2))
[warning] 127: [MP2] Context Window Stuffing: Skill attempts to fill the context window with filler content, displacing legitimate instructions and safety constraints. This can degrade agent performance or bypass safety boundaries.
Remediation: Implement context-window management that detects and rejects padding or stuffing attempts. Prioritize system instructions over user-injected content.
(Memory Poisoning (MP2))
[warning] 127: [MP2] Context Window Stuffing: Skill attempts to fill the context window with filler content, displacing legitimate instructions and safety constraints. This can degrade agent performance or bypass safety boundaries.
Remediation: Implement context-window management that detects and rejects padding or stuffing attempts. Prioritize system instructions over user-injected content.
(Memory Poisoning (MP2))
[warning] 129: [MP2] Context Window Stuffing: Skill attempts to fill the context window with filler content, displacing legitimate instructions and safety constraints. This can degrade agent performance or bypass safety boundaries.
Remediation: Implement context-window management that detects and rejects padding or stuffing attempts. Prioritize system instructions over user-injected content.
(Memory Poisoning (MP2))
[warning] 129: [MP2] Context Window Stuffing: Skill attempts to fill the context window with filler content, displacing legitimate instructions and safety constraints. This can degrade agent performance or bypass safety boundaries.
Remediation: Implement context-window management that detects and rejects padding or stuffing attempts. Prioritize system instructions over user-injected content.
(Memory Poisoning (MP2))
[warning] 132: [MP2] Context Window Stuffing: Skill attempts to fill the context window with filler content, displacing legitimate instructions and safety constraints. This can degrade agent performance or bypass safety boundaries.
Remediation: Implement context-window management that detects and rejects padding or stuffing attempts. Prioritize system instructions over user-injected content.
(Memory Poisoning (MP2))
[warning] 132: [MP2] Context Window Stuffing: Skill attempts to fill the context window with filler content, displacing legitimate instructions and safety constraints. This can degrade agent performance or bypass safety boundaries.
Remediation: Implement context-window management that detects and rejects padding or stuffing attempts. Prioritize system instructions over user-injected content.
(Memory Poisoning (MP2))
[warning] 140: [MP2] Context Window Stuffing: Skill attempts to fill the context window with filler content, displacing legitimate instructions and safety constraints. This can degrade agent performance or bypass safety boundaries.
Remediation: Implement context-window management that detects and rejects padding or stuffing attempts. Prioritize system instructions over user-injected content.
(Memory Poisoning (MP2))
[warning] 140: [MP2] Context Window Stuffing: Skill attempts to fill the context window with filler content, displacing legitimate instructions and safety constraints. This can degrade agent performance or bypass safety boundaries.
Remediation: Implement context-window management that detects and rejects padding or stuffing attempts. Prioritize system instructions over user-injected content.
(Memory Poisoning (MP2))
[warning] 142: [MP2] Context Window Stuffing: Skill attempts to fill the context window with filler content, displacing legitimate instructions and safety constraints. This can degrade agent performance or bypass safety boundaries.
Remediation: Implement context-window management that detects and rejects padding or stuffing attempts. Prioritize system instructions over user-injected content.
(Memory Poisoning (MP2))
[warning] 144: [MP2] Context Window Stuffing: Skill attempts to fill the context window with filler content, displacing legitimate instructions and safety constraints. This can degrade agent performance or bypass safety boundaries.
Remediation: Implement context-window management that detects and rejects padding or stuffing attempts. Prioritize system instructions over user-injected content.
(Memory Poisoning (MP2))
[warning] 161: [MP2] Context Window Stuffing: Skill attempts to fill the context window with filler content, displacing legitimate instructions and safety constraints. This can degrade agent performance or bypass safety boundaries.
Remediation: Implement context-window management that detects and rejects padding or stuffing attempts. Prioritize system instructions over user-injected content.
(Memory Poisoning (MP2))
[warning] 165: [MP2] Context Window Stuffing: Skill attempts to fill the context window with filler content, displacing legitimate instructions and safety constraints. This can degrade agent performance or bypass safety boundaries.
Remediation: Implement context-window management that detects and rejects padding or stuffing attempts. Prioritize system instructions over user-injected content.
(Memory Poisoning (MP2))
[warning] 166: [MP2] Context Window Stuffing: Skill attempts to fill the context window with filler content, displacing legitimate instructions and safety constraints. This can degrade agent performance or bypass safety boundaries.
Remediation: Implement context-window management that detects and rejects padding or stuffing attempts. Prioritize system instructions over user-injected content.
(Memory Poisoning (MP2))
[warning] 167: [MP2] Context Window Stuffing: Skill attempts to fill the context window with filler content, displacing legitimate instructions and safety constraints. This can degrade agent performance or bypass safety boundaries.
Remediation: Implement context-window management that detects and rejects padding or stuffing attempts. Prioritize system instructions over user-injected content.
(Memory Poisoning (MP2))
[warning] 168: [MP2] Context Window Stuffing: Skill attempts to fill the context window with filler content, displacing legitimate instructions and safety constraints. This can degrade agent performance or bypass safety boundaries.
Remediation: Implement context-window management that detects and rejects padding or stuffing attempts. Prioritize system instructions over user-injected content.
(Memory Poisoning (MP2))
[warning] 169: [MP2] Context Window Stuffing: Skill attempts to fill the context window with filler content, displacing legitimate instructions and safety constraints. This can degrade agent performance or bypass safety boundaries.
Remediation: Implement context-window management that detects and rejects padding or stuffing attempts. Prioritize system instructions over user-injected content.
(Memory Poisoning (MP2))
[warning] 170: [MP2] Context Window Stuffing: Skill attempts to fill the context window with filler content, displacing legitimate instructions and safety constraints. This can degrade agent performance or bypass safety boundaries.
Remediation: Implement context-window management that detects and rejects padding or stuffing attempts. Prioritize system instructions over user-injected content.
(Memory Poisoning (MP2))
[warning] 171: [MP2] Context Window Stuffing: Skill attempts to fill the context window with filler content, displacing legitimate instructions and safety constraints. This can degrade agent performance or bypass safety boundaries.
Remediation: Implement context-window management that detects and rejects padding or stuffing attempts. Prioritize system instructions over user-injected content.
(Memory Poisoning (MP2))
[warning] 172: [MP2] Context Window Stuffing: Skill attempts to fill the context window with filler content, displacing legitimate instructions and safety constraints. This can degrade agent performance or bypass safety boundaries.
Remediation: Implement context-window management that detects and rejects padding or stuffing attempts. Prioritize system instructions over user-injected content.
(Memory Poisoning (MP2))
[warning] 175: [MP2] Context Window Stuffing: Skill attempts to fill the context window with filler content, displacing legitimate instructions and safety constraints. This can degrade agent performance or bypass safety boundaries.
Remediation: Implement context-window management that detects and rejects padding or stuffing attempts. Prioritize system instructions over user-injected content.
(Memory Poisoning (MP2))
[warning] 176: [MP2] Context Window Stuffing: Skill attempts to fill the context window with filler content, displacing legitimate instructions and safety constraints. This can degrade agent performance or bypass safety boundaries.
Remediation: Implement context-window management that detects and rejects padding or stuffing attempts. Prioritize system instructions over user-injected content.
(Memory Poisoning (MP2))
📍 Affects 2 files
packages/react-table/skills/migrate-v8-to-v9/SKILL.md#L226-L226(this comment)packages/react-table/skills/table-state/SKILL.md#L255-L255
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/react-table/skills/migrate-v8-to-v9/SKILL.md` at line 226, Use
package-qualified declaration paths in both instructions: update
packages/react-table/skills/migrate-v8-to-v9/SKILL.md lines 226-226 to reference
node_modules/@tanstack/react-table/dist/legacy.d.ts, and update
packages/react-table/skills/table-state/SKILL.md lines 255-255 to reference
node_modules/@tanstack/react-table/dist/Subscribe.d.ts.
| ## API Discovery | ||
|
|
||
| Inspect `node_modules/@tanstack/react-table/src/index.ts` and the relevant core feature source; inspect the installed `@tanstack/react-query` source for current query option types. | ||
| Inspect `node_modules/@tanstack/react-table/dist/index.d.ts` and the relevant core feature source; inspect the installed `@tanstack/react-query` source for current query option types. |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Replace the unpublished core-source reference.
The package publication now centers API discovery on installed dist artifacts, but this step still points to “relevant core feature source.” Reference the corresponding node_modules/@tanstack/table-core/dist/*.d.ts feature declaration instead, or explicitly identify a repository-only source path.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/react-table/skills/with-tanstack-query/SKILL.md` at line 186, Update
the inspection guidance in the TanStack Query skill to replace the vague
“relevant core feature source” reference with the corresponding installed
node_modules/@tanstack/table-core/dist/*.d.ts feature declaration, or explicitly
name a repository-only source path if that is intended. Keep the existing
react-table dist and react-query source inspection guidance unchanged.
| ## API Discovery | ||
|
|
||
| Inspect installed `node_modules/@tanstack/solid-table/src/createTable.ts` and the relevant core feature source; inspect `@tanstack/solid-query` source for reactive option shapes. | ||
| Inspect installed `node_modules/@tanstack/solid-table/dist/createTable.d.ts` and the relevant core feature source; inspect `@tanstack/solid-query` source for reactive option shapes. |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Complete the installed-artifact discovery migration.
Both instructions leave readers without a reliable, explicit artifact path:
packages/solid-table/skills/with-tanstack-query/SKILL.md#L149-L149: replace the unspecified Solid Query source reference with the exact installeddistdeclarations or feature output.packages/svelte-table/skills/getting-started/SKILL.md#L172-L172: replace “the exported implementation” with the exact installeddistfile or directory.
📍 Affects 2 files
packages/solid-table/skills/with-tanstack-query/SKILL.md#L149-L149(this comment)packages/svelte-table/skills/getting-started/SKILL.md#L172-L172
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/solid-table/skills/with-tanstack-query/SKILL.md` at line 149,
Complete the installed-artifact discovery migration at
packages/solid-table/skills/with-tanstack-query/SKILL.md:149-149 by replacing
the vague Solid Query source reference with the exact installed dist
declarations or feature-output path. Also update
packages/svelte-table/skills/getting-started/SKILL.md:172-172 to replace “the
exported implementation” with the exact installed dist file or directory.
| ## API Discovery | ||
|
|
||
| Inspect `node_modules/@tanstack/table-core/src/features/column-resizing/` and the sizing feature directory for the state it updates. | ||
| Inspect `node_modules/@tanstack/table-core/dist/features/column-resizing/` and the sizing feature directory for the state it updates. |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Make every discovery path an explicit installed-package filesystem path.
Several instructions still contain bare or vague paths, so readers cannot reliably copy them when inspecting published artifacts:
packages/table-core/skills/column-resizing/SKILL.md#L91-L91: replace “the sizing feature directory” with the fullnode_modules/@tanstack/table-core/dist/features/column-sizing/path.packages/angular-table/skills/getting-started/SKILL.md#L138-L138: qualify the table-core feature path withnode_modules/.packages/angular-table/skills/table-state/SKILL.md#L197-L197: qualify@tanstack/angular-store/dist/withnode_modules/, makereactivity.d.tspackage-relative, and name the exact core dist feature path.packages/table-core/skills/global-filtering/SKILL.md#L84-L84: replace the baredist/features/column-filtering/path with its fullnode_modules/@tanstack/table-core/dist/features/column-filtering/path.
📍 Affects 4 files
packages/table-core/skills/column-resizing/SKILL.md#L91-L91(this comment)packages/angular-table/skills/getting-started/SKILL.md#L138-L138packages/angular-table/skills/table-state/SKILL.md#L197-L197packages/table-core/skills/global-filtering/SKILL.md#L84-L84
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/table-core/skills/column-resizing/SKILL.md` at line 91, Make every
discovery path explicit and relative to installed packages: in
packages/table-core/skills/column-resizing/SKILL.md:91 replace the vague sizing
feature directory with
node_modules/@tanstack/table-core/dist/features/column-sizing/; in
packages/angular-table/skills/getting-started/SKILL.md:138 prefix the table-core
feature path with node_modules/; in
packages/angular-table/skills/table-state/SKILL.md:197 prefix
`@tanstack/angular-store/dist/` with node_modules/, make reactivity.d.ts
package-relative, and use the exact node_modules/@tanstack/table-core/dist
feature path; in packages/table-core/skills/global-filtering/SKILL.md:84 replace
dist/features/column-filtering/ with
node_modules/@tanstack/table-core/dist/features/column-filtering/.
1 participant
… api discovery
🎯 Changes
✅ Checklist
pnpm test:pr.Summary by CodeRabbit
Packaging
Build Improvements
Documentation