Tighten Cloudflare install test mock types#8067
Merged
Merged
Conversation
gonzaloriestra
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
No issue.
The Cloudflare installer tests mocked
http.fetchwith a partial response object cast toany. The production helper expects thenode-fetchresponse shape, so the test can use a realResponseinstead of bypassing types.WHAT is this pull request doing?
new Response(...)fromnode-fetch.Readablestream import and theas anycast from the fetch mock.How to test your changes?
pnpm --filter @shopify/plugin-cloudflare vitest src/install-cloudflared.test.ts✅pnpm --filter @shopify/plugin-cloudflare type-check✅pnpm --filter @shopify/plugin-cloudflare lint✅git diff --check✅Post-release steps
None.
Checklist