Target specs v3#484
Merged
Merged
Conversation
Firestar99
force-pushed
the
target-specs-v3
branch
2 times, most recently
from
December 11, 2025 17:14
60bcb50 to
c290339
Compare
nazar-pc
reviewed
Dec 11, 2025
Firestar99
force-pushed
the
target-specs-v3
branch
from
December 11, 2025 18:44
c290339 to
c7d9772
Compare
This was referenced Dec 12, 2025
Firestar99
force-pushed
the
target-specs-v3
branch
2 times, most recently
from
December 15, 2025 11:19
9dd737d to
823b0c2
Compare
Firestar99
marked this pull request as ready for review
December 15, 2025 12:18
This was referenced Dec 17, 2025
Merged
Collaborator
|
@eddyb thoughts? |
eddyb
approved these changes
Dec 24, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Dec 25, 2025
Firestar99
force-pushed
the
target-specs-v3
branch
from
December 25, 2025 10:56
a64583d to
a7ae998
Compare
Firestar99
enabled auto-merge
December 25, 2025 10:56
Member
Author
|
merge failed due to lockfile conflicts, rebasing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wanted to simply target specs even more:
rustc_codegen_spirv-target-specsspirv-unknown-*.jsontarget spec files in the repospirv-unknown-vulkan1.3) and target envs (vulkan1.3)rust-gpu/crates/rustc_codegen_spirv-types/src/target.rs
Lines 8 to 11 in 823b0c2
enum SpirvTargetEnvcontaining all available targets #311 having had a lot of discussions on how to represent targets properly