DEV-121748 | refactor: Change total price validation to negative only#192
Merged
DavidRibeiroRiskified merged 1 commit intoJan 13, 2026
Conversation
bernardodemelo
previously approved these changes
Jan 7, 2026
tomas-amaro
approved these changes
Jan 12, 2026
tomas-amaro
previously approved these changes
Jan 12, 2026
DavidRibeiroRiskified
force-pushed
the
refactor/DEV-121748-change-validation-total-price
branch
2 times, most recently
from
January 13, 2026 09:41
23cd057 to
6fedc8b
Compare
DavidRibeiroRiskified
changed the base branch from
upkeep/update-jdk
to
master
January 13, 2026 09:41
DavidRibeiroRiskified
dismissed stale reviews from tomas-amaro and bernardodemelo
January 13, 2026 09:41
The base branch was changed.
DavidRibeiroRiskified
force-pushed
the
refactor/DEV-121748-change-validation-total-price
branch
from
January 13, 2026 09:47
6fedc8b to
773feb2
Compare
tomas-amaro
approved these changes
Jan 13, 2026
DavidRibeiroRiskified
deleted the
refactor/DEV-121748-change-validation-total-price
branch
January 13, 2026 10:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per Eli's comment in the ticket, orders can have a total value of 0, so we should allow that