fix: verify_install Check F stale dataset + mixed dev/released stack#71
Merged
Conversation
…released stack Check F (Colab simulation) FAILed while the real install path (A/C/D) was green, failing the whole verify_install_release job (release-validation run 29266305445). 1. F_driver loaded dataset/imaging/simple/*.fits — a path start_here.py no longer uses and which isn't bundled → FileNotFoundError. Load the bundled cosmos_web_ring JWST dataset (pixel_scales=0.06) the current start_here.py actually loads (why Check A passes); no simulator needed. 2. The emulated-Colab install pinned only autolens to the dev version, letting the four sibling deps resolve to the latest final on PyPI. When a version is pinned, pin all five PyAuto packages so Check F exercises a coherent dev stack. Harness-only; Checks A/C/D untouched. Fixes #70 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TDCsgNCXacXqiWAPTswWCt
Jammy2211
added
the
pending-release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
verify_installCheck F (Colab simulation) FAILed even though the real new-user path (Checks A/C/D) was green, failing the wholeverify_install_releasejob (release-validation run29266305445). Both problems are isolated toheart/checks/verify_install.sh'scheck_f().Fixes
cosmos_web_ring. The generatedF_driver.pyloadeddataset/imaging/simple/*.fits— a pathimaging/start_here.pyno longer uses and which isn't bundled →FileNotFoundError. It now loads the bundledcosmos_web_ringJWST dataset (pixel_scales=0.06) the currentstart_here.pyactually loads — one of the few example datasets that ship committed, present after thesetup_colabclone. No simulator needed. (The issue guessed asimpleauto-simulate;start_heredoesn't usesimple.)$TARGET_VERSIONis set (a TestPyPI rehearsal), the emulated-Colab install now pins all five PyAuto packages to it, instead of pinning onlyautolensand lettingautoarray/autoconf/autofit/autogalaxyresolve to the latest final on PyPI. The later verbatimpip install autoconf --no-depsthen finds the pinned dev autoconf already satisfied → no-op. Released (unpinned) mode is unchanged.Checks A/C/D untouched.
Verification
bash -n verify_install.shOK; extractedF_driver.py→py_compileOK.cosmos_web_ring/{data,noise_map,psf}.fitsconfirmed committed inautolens_workspace.pytest tests/→ 263 passed.F PASSis confirmed by the next release-validation rehearsal.API Changes
None — harness-only (one shell function).
Fixes #70
🤖 Generated with Claude Code
https://claude.ai/code/session_01TDCsgNCXacXqiWAPTswWCt