Combine Skills and MCP servers into a single "Skills and MCP" tab#3383
Combine Skills and MCP servers into a single "Skills and MCP" tab#3383k11kirky wants to merge 2 commits into
Conversation
One sidebar destination with the Plugs icon; each half keeps its own route (/skills, /mcp-servers, and the /website mirrors) and a shared top-level tab strip switches between them, so deep links, browser tabs, and back/forward keep working. Generated-By: PostHog Code Task-Id: a92a9add-0a17-40a1-9bf8-ca43d76661f3
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
|
Reviews (1): Last reviewed commit: "Combine Skills and MCP servers into one ..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| @@ -167,11 +162,7 @@ export function SidebarNavSection({ | |||
| </Box> | |||
There was a problem hiding this comment.
When the current route is /mcp-servers or /website/mcp-servers, this combined sidebar item is highlighted as active but still runs goSkills on click. A click on the active nav item then moves the user from MCP servers to Skills and can discard the MCP view’s current scroll or selection state.
Clicking the combined item while on /mcp-servers navigated back to /skills, dropping the MCP view's state. Guard the click when either half is already open; covered by a new SidebarNavSection test. Generated-By: PostHog Code Task-Id: a92a9add-0a17-40a1-9bf8-ca43d76661f3
1 participant
Problem
Skills and MCP servers are both "extend your agent" surfaces but lived as two separate sidebar tabs, taking up nav space and splitting a single mental model across two destinations.
Why
Requested by Peter: merge the Skills and MCP tabs into one "Skills and MCP" tab (using the current MCP servers icon) while keeping both views easy to reach.
Changes
SkillsMcpTabs) renders at the top of both views to switch between Skills and MCP servers. Each half keeps its own route (/skills,/mcp-servers, and the/websitemirrors), so switching navigates — deep links, browser tabs, and back/forward all keep working. The Skills sub-tabs (Installed / Team / Marketplace) are unchanged beneath it.How did you test this?
turbo typecheck --filter=@posthog/ui— clean.pnpm --filter @posthog/ui test— 1504 tests passed.biome checkon the touched feature directories — clean.Automatic notifications
Created with PostHog Code