Skip to content

fix(mcp): include tool names in policy logs#2189

Merged
johntmyers merged 1 commit into
mainfrom
kirit93/mcp-logging
Jul 10, 2026
Merged

fix(mcp): include tool names in policy logs#2189
johntmyers merged 1 commit into
mainfrom
kirit93/mcp-logging

Conversation

@kirit93

@kirit93 kirit93 commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

Adds mcp tool name to openshell sandbox logs

Testing

  • mise run pre-commit passes
  • Unit tests added/updated

Checklist

Signed-off-by: Kirit93 <kthadaka@nvidia.com>
@johntmyers

Copy link
Copy Markdown
Collaborator

gator-agent

Maintainer Approval Needed

Gator validation and PR monitoring are complete.

Validation: PR #2189 is project-valid as a small, maintainer-authored MCP logging fix scoped to JSON-RPC policy log output.
Head SHA: 03ea5d8b779888ce23e19bd2dab5cb15bd88c525

Review: Independent code review found no critical or warning-level findings. The change keeps tool names sanitized for log output and adds unit coverage for allowed, denied, and non-tool JSON-RPC cases.
Docs: No Fern docs update required; this changes internal policy log detail rather than a documented user workflow or CLI/API contract.
Checks: Required Branch Checks, Helm Lint, DCO, and vouch gates are passing.
E2E: N/A; no test:* label is needed for this log-format-only change.

Human maintainer approval is now required.

@johntmyers johntmyers added the gator:approval-needed Gator completed review; maintainer approval needed label Jul 9, 2026
@johntmyers johntmyers merged commit ccdac9c into main Jul 10, 2026
34 checks passed
@johntmyers johntmyers deleted the kirit93/mcp-logging branch July 10, 2026 15:38
@johntmyers

Copy link
Copy Markdown
Collaborator

gator-agent

Monitoring Complete

Monitoring is complete because this PR has merged.

Final status: PR #2189 was in gator:approval-needed; required checks were green, maintainer approval was present, and the PR merged at 2026-07-10T15:38:26Z.

I removed the active gator:* label because there is nothing left for gator to monitor on this PR.

@johntmyers johntmyers removed the gator:approval-needed Gator completed review; maintainer approval needed label Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants