Skip to content

bigfeat: detector changed hook#905

Closed
baltzell wants to merge 54 commits into
developmentfrom
detector-changed-hook
Closed

bigfeat: detector changed hook#905
baltzell wants to merge 54 commits into
developmentfrom
detector-changed-hook

Conversation

@baltzell

@baltzell baltzell commented Oct 23, 2025

Copy link
Copy Markdown
Collaborator

No description provided.

@baltzell baltzell added this to the Real Run Number Simulations milestone Oct 23, 2025
@baltzell baltzell added the gemc label Oct 23, 2025
@baltzell
baltzell force-pushed the detector-changed-hook branch 3 times, most recently from 509c95a to 8492640 Compare November 13, 2025 23:25
@baltzell baltzell mentioned this pull request Dec 3, 2025
Closed
@baltzell
baltzell force-pushed the detector-changed-hook branch 3 times, most recently from cbbe1a5 to 5f34968 Compare December 12, 2025 20:30
@baltzell
baltzell force-pushed the detector-changed-hook branch 4 times, most recently from 97bf69f to d290802 Compare December 23, 2025 15:39
@baltzell baltzell mentioned this pull request Jan 9, 2026
Closed
@baltzell
baltzell force-pushed the detector-changed-hook branch from e84fd3e to 124232c Compare January 12, 2026 15:01
@baltzell

baltzell commented Jan 12, 2026

Copy link
Copy Markdown
Collaborator Author

If not already done, #441's changes should be included here.

@baltzell
baltzell force-pushed the detector-changed-hook branch from 1563cd9 to 136de6f Compare January 16, 2026 01:27
@baltzell
baltzell force-pushed the detector-changed-hook branch 3 times, most recently from 3ecf271 to 24e9a86 Compare February 6, 2026 01:28
@baltzell baltzell changed the title Detector changed hook feat: detector changed hook Feb 21, 2026
@baltzell baltzell changed the title feat: detector changed hook bigfeat: detector changed hook Feb 26, 2026
@baltzell
baltzell force-pushed the detector-changed-hook branch from 24e9a86 to 337fb8d Compare March 3, 2026 00:44
@baltzell
baltzell force-pushed the detector-changed-hook branch from 337fb8d to 4ed1dfb Compare March 15, 2026 01:12
@baltzell

baltzell commented Mar 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

@raffaelladevita We have this error after updating this branch in recent weeks:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.15.0:compile (default-compile) on project clas12detector-urwt: Compilation failure
[ERROR] /Users/baltzell/sw/coatjava/reconstruction/urwt/src/main/java/org/jlab/service/urwt/URWTEngine.java:[58,33] cannot find symbol
[ERROR]   symbol:   variable URWellConstants
[ERROR]   location: class org.jlab.service.urwt.URWTEngine

@baltzell
baltzell force-pushed the detector-changed-hook branch 2 times, most recently from a86097f to 43a4321 Compare March 20, 2026 22:22
@baltzell
baltzell force-pushed the detector-changed-hook branch from 7ff09b9 to ba3d324 Compare April 2, 2026 00:50
baltzell and others added 27 commits April 16, 2026 21:15
@baltzell
abort on error
b7be12d
@baltzell
fix rebase mistake
d150f8f
@baltzell
add missing overrides
20962f5
@baltzell
add missing overrides
dd2a400
@baltzell
add missing overrides
7fbda4e
@raffaelladevita @baltzell
accounting for tstart, tflight and tprop in MC tracks reconstruction
efefde7
@raffaelladevita @baltzell
removed check on run number when setting the DC hit uncertainty
44ac6c7
@raffaelladevita @baltzell
removed hardcoded change to default variation in BAND engine
6542fb6
@raffaelladevita @baltzell
apply TDC jitter correction only if TI timestamp is >0, excluding MC …
9d72f5f 
…events
@raffaelladevita @baltzell
moved RF offsets to time written to RUN::rf bank
8da5410
@raffaelladevita @baltzell
fixed bug in REC::Event.RFTime introduced with last commit
4387742
@raffaelladevita @baltzell
restored TDC jitter correction for timestamp=0
0d066a2
@raffaelladevita @baltzell
switch to load geometry for real run number
00d36d4
@baltzell
fix env
cbcc978
@baltzell
add missing override
d466af7
@baltzell
remove unused imports
a347af8
@baltzell
set PATH
168875a
@baltzell
add missing overrides
c86bb65
@baltzell
add missing overrides
802cc3a
@raffaelladevita @baltzell
propagate detectorChanged and method renaming to new UberEngine
0503e28
@raffaelladevita @baltzell
changed EC to load the geometry with the real run number
09e7b7a
@baltzell
fix merge mistake
273bed3
@raffaelladevita @baltzell
undoing RF offset changes
7dfdf6b
@baltzell
add missing overrides
a0f8643
@raffaelladevita @baltzell
updated use of geometry factory in URWT engine
2cb383d
@baltzell
cleanup
0df0d03
@baltzell
add detector changed hooks
1538ec0
@baltzell
baltzell force-pushed the detector-changed-hook branch from 387ef9b to 1538ec0 Compare April 17, 2026 01:15
@baltzell baltzell closed this Apr 17, 2026
@baltzell baltzell mentioned this pull request Apr 17, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raffaelladevita raffaelladevita Awaiting requested review from raffaelladevita raffaelladevita will be requested when the pull request is marked ready for review raffaelladevita is a code owner
@c-dilks c-dilks Awaiting requested review from c-dilks c-dilks will be requested when the pull request is marked ready for review c-dilks is a code owner
@zieglerv zieglerv Awaiting requested review from zieglerv zieglerv will be requested when the pull request is marked ready for review zieglerv is a code owner
@tongtongcao tongtongcao Awaiting requested review from tongtongcao tongtongcao will be requested when the pull request is marked ready for review tongtongcao is a code owner
@mathieuouillon mathieuouillon Awaiting requested review from mathieuouillon mathieuouillon will be requested when the pull request is marked ready for review mathieuouillon is a code owner
@Hattawy Hattawy Awaiting requested review from Hattawy Hattawy will be requested when the pull request is marked ready for review Hattawy is a code owner
@drewkenjo drewkenjo Awaiting requested review from drewkenjo drewkenjo will be requested when the pull request is marked ready for review drewkenjo is a code owner
@mcontalb mcontalb Awaiting requested review from mcontalb mcontalb will be requested when the pull request is marked ready for review mcontalb is a code owner
@silvianic silvianic Awaiting requested review from silvianic silvianic will be requested when the pull request is marked ready for review silvianic is a code owner
@N-Plx N-Plx Awaiting requested review from N-Plx N-Plx will be requested when the pull request is marked ready for review N-Plx is a code owner
@rafopar rafopar Awaiting requested review from rafopar rafopar will be requested when the pull request is marked ready for review rafopar is a code owner
@forcar forcar Awaiting requested review from forcar forcar will be requested when the pull request is marked ready for review forcar is a code owner
@hauenst hauenst Awaiting requested review from hauenst hauenst will be requested when the pull request is marked ready for review hauenst is a code owner
@ajhobart ajhobart Awaiting requested review from ajhobart ajhobart will be requested when the pull request is marked ready for review ajhobart is a code owner
@mpaolone mpaolone Awaiting requested review from mpaolone mpaolone will be requested when the pull request is marked ready for review mpaolone is a code owner
@efuchey efuchey Awaiting requested review from efuchey efuchey will be requested when the pull request is marked ready for review efuchey is a code owner
@whit2333 whit2333 Awaiting requested review from whit2333 whit2333 will be requested when the pull request is marked ready for review whit2333 is a code owner
@ftouchte ftouchte Awaiting requested review from ftouchte ftouchte will be requested when the pull request is marked ready for review ftouchte is a code owner
@heddle heddle Awaiting requested review from heddle heddle will be requested when the pull request is marked ready for review heddle is a code owner

Assignees

No one assigned

Labels

gemc

Projects

None yet

Milestone

Real Run Number Simulations

Development

Successfully merging this pull request may close these issues.

2 participants

@baltzell @raffaelladevita