Skip to content

Update NRL adp-preprocessors, add sdp-preprocessors#2060

Open
climbfuji wants to merge 10 commits into
JCSDA:developfrom
climbfuji:feature/sdp
Open

Update NRL adp-preprocessors, add sdp-preprocessors#2060
climbfuji wants to merge 10 commits into
JCSDA:developfrom
climbfuji:feature/sdp

Conversation

@climbfuji

@climbfuji climbfuji commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Description

Update adp-preprocessors after merging spack-related PRs into the authoritative code base. Introduce new package sdp-preprocessors.

Dependencies

None (everything upstream is merged).

TO VERIFY

Issues addressed

NRL internal issue.

Applications affected

FALCON DA

Systems affected

None directly

Testing

  • CI: Note whether the automatic tests (GitHub actions tests that run automatically for every commit) pass or not
    • GitHub actions CI tests pass - note: these do not build adp-preprocessors and sdp-preprocessors
    • GitHub actions CI tests do not pass (provide explanation)
    • GitHub actions CI tests skipped (provide explanation if necessary)
  • New tests added: List and describe any new tests added to GitHub actions
    • ...
  • Additional testing: Add information on any additional tests conducted
    • Built adp-preprocessors and sdp-preprocessorson Narwhal and Nautilus, each time withgccandoneapi`
    • TODO

Checklist

  • This PR addresses one issue/problem/enhancement or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications. TODO
  • All dependency PRs/issues have been resolved and this PR can be merged. TO VERIFY
  • All necessary updates to the documentation (spack-stack wiki) will be made when this PR is merged

@climbfuji climbfuji self-assigned this Jul 15, 2026
@climbfuji climbfuji added the NAVY United States Naval Research Lab label Jul 15, 2026
@climbfuji climbfuji moved this from Todo to In Progress in spack-stack-2.2.x (2026 Q?) Jul 15, 2026
Comment on lines +23 to +29
# These are not official versions; 1.1.1 lives in @climbfuji's fork.
version("1.1.2", commit="729b0e7572a497b1103d0b8b1e6ff3972efd0d29")
version(
"1.1.1",
git="https://github.nrlmry.navy.mil/climbfuji/adp-preprocessors.git",
commit="c6f15e46496309c3893416ba4ccec7f003b93550"
)

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no official versions/tags that can be built with spack-stack, just commits. None of these have ever been used, hence we can rewind the clock and use these version numbers. Makes it easier in the future.

for subdir in ['bin', 'etc', 'lib', 'mod']:
copy_tree(join_path(self.stage.source_path, subdir), join_path(prefix, subdir))

# DH* 20260529 todo: configure tests

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep this (from adp-preprocessors) until instructions are given for testing sdp-preprocessors.

@climbfuji climbfuji marked this pull request as ready for review July 15, 2026 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NAVY United States Naval Research Lab

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

1 participant