handle null argument in range function#758
Merged
Merged
Conversation
boulter
commented
Sep 30, 2021
| switch (args.length) { | ||
| case 0: | ||
| if (NumberUtils.isNumber(arg1.toString())) { | ||
| if (NumberUtils.isCreatable(arg1.toString())) { |
Contributor
Author
There was a problem hiding this comment.
deprecated function
jasmith-hs
approved these changes
Sep 30, 2021
jasmith-hs
left a comment
jasmith-hs
left a comment
Contributor
There was a problem hiding this comment.
Similarly, the ENGINE_LOG is used in the TruncateHtmlFilter. It would be nice to have that add an error too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing a null argument to the range function would throw a NullPointerException instead of being handled as an interpret error. That's fixed now.
I also logged template errors for bad values in the truncate and truncateHtml functions instead of using the ENGINE_LOG which no one looks at.