[Eager Execution] Don't track context classes with default toString method#583
Merged
Conversation
jasmith-hs
force-pushed
the
jasmith-patch
branch
from
5f6325a to
89429e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #532
Classes that don't override the default
Object.toString()were never envisioned to be output as a string so we don't need to be tracking them for changes to potentially output them as a string during eager execution. This will be supplemented with #581, which will allow for more optimizations to the python string representation of objects.If one of these objects does see a change in its hash code, since we aren't trying to output it as a string, then we must throw a
DeferredValueException, which will result in the calling node becoming a deferred node, rather than utilizing the functionality of theeagerTokens. If that happens, then the final render will need to be redone, rather than using the result from eager execution.