Use strategy pattern for ExpressionNode functionality#544
Merged
Conversation
This was referenced Nov 23, 2020
Closed
boulter
approved these changes
Nov 23, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #532
Depends on #543
Introducing the strategy pattern into the ExpressionNode, similar to how it works in the TagNode, allows for the interpretation functionality to not be coupled directly to the concept of an ExpressionNode. This allows for different approaches or strategies to interpreting an ExpressionNode.
For Eager Execution, the ExpressionNode needs to be interpreted slightly differently so rather than adding multiple approaches in the ExpressionNode class, it is better to abstract the functionality into this new
interface ExpressionStrategy.There is a DefaultExpressionStrategy for the current ExpressionNode's functionality, and there is a skeleton added for the functionality that will be used when performing eager execution, called EagerExpressionStrategy.