Accept ip address without network prefix in ipaddr('address') filter#512
Merged
mattcoley merged 1 commit intoSep 28, 2020
Merged
Accept ip address without network prefix in ipaddr('address') filter#512mattcoley merged 1 commit into
mattcoley merged 1 commit into
Conversation
Author
|
The failing test case is DateTimeFormatFilterTest.itDefaultsToEnglishForBadLocaleValues, and it fails in a clean master too. |
mattcoley
approved these changes
Sep 28, 2020
Collaborator
|
Hmm that is because the build is targeting Java 8 vs. 11. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In jinja2 with netaddr, the ipaddr('address') filter accepts a plain ip address, like "192.168.0.1". Jinjava currently rejects this because it has no network prefix. This patch fixes the jinjava behaviour for these cases.