disallow adding a map to itself#474
Merged
Merged
Conversation
hs-lsong
reviewed
Aug 14, 2020
| @Override | ||
| public void putAll(Map<? extends K, ? extends V> m) { | ||
| public void putAll(@Nonnull Map<? extends K, ? extends V> m) { | ||
| for (Entry<? extends K, ? extends V> entry : m.entrySet()) { |
Collaborator
There was a problem hiding this comment.
Since you are iterating the entries, can you just call put(key, value) for each of the entry, and skip the scope.putAll(m)?
Contributor
Author
There was a problem hiding this comment.
The HashMap implementation of putAll has some optimizations for inserting multiple entries, so I didn't want to override that.
hs-lsong
approved these changes
Aug 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since serializing a map with references to itself is disasterous, let's try to prevent that when adding things to the map.