Remove hacky replaceL behavior#407
Merged
Merged
Conversation
Contributor
|
Probably had something do with python compatibility? Worth checking for differences in any case. |
Collaborator
Author
|
That's my plan. I am not sure how this would affect python compatibility since python would be using the stftime format with |
Collaborator
Author
|
I ran the diff report 5 times. The only diffs were expected. Languages that have genitive months are now properly using the genitive format. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This behavior has been here since initial commit but is pretty strange. Basically if we detect the format is a Java format rather than strftime format, we return the Java format back but replace all
LLLLinstances withMMMM. This means we can't manually specifyLLLLwhen that is the appropriate format we want.