Skip to content

Add python list operations to PyList#362

Merged
mattcoley merged 3 commits into
masterfrom
prepend-list
Aug 21, 2019
Merged

Add python list operations to PyList#362
mattcoley merged 3 commits into
masterfrom
prepend-list

Conversation

@mattcoley

@mattcoley mattcoley commented Aug 21, 2019

Copy link
Copy Markdown
Collaborator

Extended PyList to support most of the python list operations (https://docs.python.org/3/tutorial/datastructures.html).

One issue is with the remove() function which I cannot overload.

@mattcoley mattcoley requested a review from liamrharwood August 21, 2019 14:02
@boulter

boulter commented Aug 21, 2019

Copy link
Copy Markdown
Contributor

This seems like something that's not supported in Jinja. In python, you prepend with .insert. That would be preferable to something completely proprietary.

@mattcoley

Copy link
Copy Markdown
Collaborator Author

👍 Makes sense, let me change this.

@mattcoley mattcoley changed the title Add prepend operation to list Add python list operations to PyList Aug 21, 2019
@mattcoley

Copy link
Copy Markdown
Collaborator Author

Ok @boulter I added functions to PyList to make it similar to a regular python list.

@mattcoley mattcoley merged commit e867e3e into master Aug 21, 2019
@mattcoley mattcoley deleted the prepend-list branch August 21, 2019 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants