Skip to content

Support nominative date formats.#330

Merged
mattcoley merged 2 commits into
masterfrom
nominative-formats
May 15, 2019
Merged

Support nominative date formats.#330
mattcoley merged 2 commits into
masterfrom
nominative-formats

Conversation

@mattcoley

Copy link
Copy Markdown
Collaborator

Some languages have two version of months (nominative and genitive). By default, JDK8 uses genitive format which can cause issues. This allows you to use %OB instead of %B to get the nominative version of the month name.

@codecov-io

codecov-io commented May 15, 2019

Copy link
Copy Markdown

Codecov Report

Merging #330 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #330      +/-   ##
============================================
+ Coverage     71.51%   71.56%   +0.05%     
- Complexity     1576     1578       +2     
============================================
  Files           239      239              
  Lines          4957     4966       +9     
  Branches        800      802       +2     
============================================
+ Hits           3545     3554       +9     
  Misses         1126     1126              
  Partials        286      286
Impacted Files Coverage Δ Complexity Δ
...ubspot/jinjava/objects/date/StrftimeFormatter.java 88.5% <100%> (+1.32%) 20 <0> (+2) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f9cfbb...a8181c8. Read the comment docs.

@anev

anev commented May 15, 2019

Copy link
Copy Markdown
Contributor

LGTM

@mattcoley mattcoley merged commit c3c310a into master May 15, 2019
@mattcoley mattcoley deleted the nominative-formats branch May 15, 2019 16:43
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.56%. Comparing base (5f9cfbb) to head (a8181c8).
⚠️ Report is 2546 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #330      +/-   ##
============================================
+ Coverage     71.51%   71.56%   +0.05%     
- Complexity     1576     1578       +2     
============================================
  Files           239      239              
  Lines          4957     4966       +9     
  Branches        800      802       +2     
============================================
+ Hits           3545     3554       +9     
  Misses         1126     1126              
  Partials        286      286              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants