Support nominative date formats.#330
Merged
Merged
Conversation
added 2 commits
May 15, 2019 12:14
Codecov Report
@@ Coverage Diff @@
## master #330 +/- ##
============================================
+ Coverage 71.51% 71.56% +0.05%
- Complexity 1576 1578 +2
============================================
Files 239 239
Lines 4957 4966 +9
Branches 800 802 +2
============================================
+ Hits 3545 3554 +9
Misses 1126 1126
Partials 286 286
Continue to review full report at Codecov.
|
Contributor
|
LGTM |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #330 +/- ##
============================================
+ Coverage 71.51% 71.56% +0.05%
- Complexity 1576 1578 +2
============================================
Files 239 239
Lines 4957 4966 +9
Branches 800 802 +2
============================================
+ Hits 3545 3554 +9
Misses 1126 1126
Partials 286 286 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some languages have two version of months (nominative and genitive). By default, JDK8 uses genitive format which can cause issues. This allows you to use
%OBinstead of%Bto get the nominative version of the month name.