Skip to content

Add a warning when there is no matching start tag for an end tag#326

Merged
liamrharwood merged 1 commit into
masterfrom
warn-missing-start-tag
Apr 30, 2019
Merged

Add a warning when there is no matching start tag for an end tag#326
liamrharwood merged 1 commit into
masterfrom
warn-missing-start-tag

Conversation

@liamrharwood

Copy link
Copy Markdown
Contributor

The following syntax is allowed by Jinjava:

{% if true %}
foo
{% endif %}
{% endif %}

This causes no issues in isolation, but can result in mismatched end tags when inserted in the middle of a template such as in a generated module_attribute tag. Adding a warning will help make this danger more apparent and prevent cases such as this from causing problems.

@liamrharwood liamrharwood merged commit ce57093 into master Apr 30, 2019
@liamrharwood liamrharwood deleted the warn-missing-start-tag branch April 30, 2019 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants