Skip to content

Fix cycle reference during serialization.#319

Merged
hs-lsong merged 1 commit into
masterfrom
fix-recursive-reference
Apr 10, 2019
Merged

Fix cycle reference during serialization.#319
hs-lsong merged 1 commit into
masterfrom
fix-recursive-reference

Conversation

@hs-lsong

Copy link
Copy Markdown
Collaborator

And also remove some un-used fields.

cc @liamrharwood

@hs-lsong hs-lsong requested a review from boulter April 10, 2019 17:10
@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #319 into master will decrease coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #319      +/-   ##
============================================
- Coverage     71.43%   71.32%   -0.11%     
+ Complexity     1562     1558       -4     
============================================
  Files           239      239              
  Lines          4926     4918       -8     
  Branches        793      793              
============================================
- Hits           3519     3508      -11     
- Misses         1124     1126       +2     
- Partials        283      284       +1
Impacted Files Coverage Δ Complexity Δ
...java/com/hubspot/jinjava/lib/fn/MacroFunction.java 100% <ø> (ø) 9 <0> (-3) ⬇️
...main/java/com/hubspot/jinjava/lib/tag/CallTag.java 100% <100%> (ø) 3 <0> (ø) ⬇️
...ain/java/com/hubspot/jinjava/lib/tag/MacroTag.java 82.75% <100%> (-1.62%) 8 <0> (ø)
...in/java/com/hubspot/jinjava/lib/tag/ImportTag.java 80.95% <0%> (-7.15%) 7% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f1895c...f5ac73e. Read the comment docs.

@hs-lsong hs-lsong merged commit 1ad2e62 into master Apr 10, 2019
@hs-lsong hs-lsong deleted the fix-recursive-reference branch April 10, 2019 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants