Fix expression resolver in import tag.#290
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #290 +/- ##
===========================================
+ Coverage 72.28% 72.3% +0.01%
Complexity 1497 1497
===========================================
Files 234 234
Lines 4648 4651 +3
Branches 739 739
===========================================
+ Hits 3360 3363 +3
Misses 1033 1033
Partials 255 255
Continue to review full report at Codecov.
|
jboulter
approved these changes
Feb 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When doing
{% import x as y %}we create a new child interpreter and use that to render the imported template and then copy over errors/macros. The issue is that the expression resolver uses the staticJinjavaIntepreter.currentIntepreter()to resolve expressions, meaning that we are using the parent interpreter to resolve expressions in the child interpreter's render.