Allow null in string exp tests.#278
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #278 +/- ##
============================================
+ Coverage 72.32% 72.35% +0.02%
- Complexity 1481 1483 +2
============================================
Files 231 231
Lines 4593 4597 +4
Branches 735 737 +2
============================================
+ Hits 3322 3326 +4
Misses 1016 1016
Partials 255 255
Continue to review full report at Codecov.
|
boulter
approved these changes
Feb 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously passing in null would result in an
InterpretExceptionbeing thrown resulting in a template error stating that no argument was passed in. It makes better sense to return false for these tests when a null value is used. I also added tests for both string expression tests.