Add common set theory filters.#262
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #262 +/- ##
============================================
+ Coverage 71.96% 72.05% +0.09%
- Complexity 1437 1453 +16
============================================
Files 226 231 +5
Lines 4515 4534 +19
Branches 717 718 +1
============================================
+ Hits 3249 3267 +18
Misses 1014 1014
- Partials 252 253 +1
Continue to review full report at Codecov.
|
boulter
requested changes
Dec 18, 2018
| import com.hubspot.jinjava.util.ObjectIterator; | ||
|
|
||
| @JinjavaDoc( | ||
| value = "Returns a list containing elements present in the first list and not the second list", |
| @Override | ||
| public Object filter(Object var, JinjavaInterpreter interpreter, Object[] args, Map<String, Object> kwargs) { | ||
|
|
||
| LinkedHashSet<Object> result = new LinkedHashSet<>(); |
Contributor
There was a problem hiding this comment.
How about using Sets.union?
Collaborator
Author
There was a problem hiding this comment.
The reason I did not use the set function helpers is that they would be slower/require more space. I would need to loop over the two iterables to form the sets, then apply those functions. This wouldn't be noticeable for small sets but might be for large sets. The functions are pretty simple anyways, and I'm not using the set helper functions is worth it but it's up to you.
| @Override | ||
| public Object filter(Object var, JinjavaInterpreter interpreter, Object[] args, Map<String, Object> kwargs) { | ||
|
|
||
| Set<Object> keysFirst = new HashSet<>(); |
| @Override | ||
| public Object filter(Object var, JinjavaInterpreter interpreter, Object[] args, Map<String, Object> kwargs) { | ||
|
|
||
| Set<Object> keys = new HashSet<>(); |
| Set<Object> keys = new HashSet<>(); | ||
| Set<Object> result = new LinkedHashSet<>(); | ||
|
|
||
| Object attr = null; |
Collaborator
Author
|
@boulter Refactored to use the |
boulter
approved these changes
Dec 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #261
Adds
union,intersect,difference, andsymmetric_differencesimilar to Ansible https://ansible-docs.readthedocs.io/zh/stable-2.0/rst/playbooks_filters.html#set-theory-filters.