Support timezone conversions in datetimeformat filter.#241
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #241 +/- ##
============================================
+ Coverage 71.64% 71.86% +0.22%
- Complexity 1380 1387 +7
============================================
Files 219 219
Lines 4338 4358 +20
Branches 683 687 +4
============================================
+ Hits 3108 3132 +24
+ Misses 996 992 -4
Partials 234 234
Continue to review full report at Codecov.
|
added 2 commits
October 11, 2018 13:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #239
Allows you to add an optional variable to the
datetimeformatfilter to specify which timezone the result should be converted to. For example,|datetimeformat("%B %d, %Y, at %I:%M %p", "America/New_York")will output the time in EST instead of UTC. If no timezone is given, it will default to UTC like before. If the timezone is not valid, it will throw anInvalidDateFormatException