Adds ipaddr filter to test if string is valid IP Address.#237
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #237 +/- ##
============================================
+ Coverage 71.6% 71.64% +0.03%
- Complexity 1378 1386 +8
============================================
Files 218 219 +1
Lines 4350 4363 +13
Branches 689 693 +4
============================================
+ Hits 3115 3126 +11
- Misses 999 1000 +1
- Partials 236 237 +1
Continue to review full report at Codecov.
|
boulter
reviewed
Sep 19, 2018
| } | ||
|
|
||
| if (object instanceof String) { | ||
| String address = (String) object; |
Contributor
There was a problem hiding this comment.
Should this do a trim() first?
Collaborator
Author
There was a problem hiding this comment.
Yea that would be smart.
added 2 commits
September 19, 2018 10:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for #236
Adds
ipaddrfilter to test if string is valid IPv4 or IPv6 filter. Checking IPv6 is tricky due to the compression, however the regex seems to be working against the tests.