disallow returning Class objects#232
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #232 +/- ##
============================================
+ Coverage 71.46% 71.49% +0.03%
- Complexity 1375 1377 +2
============================================
Files 218 218
Lines 4349 4354 +5
Branches 689 691 +2
============================================
+ Hits 3108 3113 +5
Misses 1000 1000
Partials 241 241
Continue to review full report at Codecov.
|
kenbreeman
reviewed
Aug 31, 2018
| private static final Set<String> RESTRICTED_METHODS = ImmutableSet.<String> builder() | ||
| .add("clone") | ||
| .add("hashCode") | ||
| .add("getClass") |
There was a problem hiding this comment.
let's leave this in, layers are good
Contributor
Author
There was a problem hiding this comment.
ok, I took it out mostly so I could test the new method of blocking, but I'll put it back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Class objects have security issues.