Deepen equalto expression test comparison.#211
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #211 +/- ##
=========================================
Coverage 71.36% 71.36%
Complexity 1353 1353
=========================================
Files 215 215
Lines 4282 4282
Branches 683 683
=========================================
Hits 3056 3056
Misses 985 985
Partials 241 241
Continue to review full report at Codecov.
|
mattcoley
changed the title
boulter
requested changes
Jul 17, 2018
boulter
left a comment
boulter
left a comment
Contributor
There was a problem hiding this comment.
Could you provide some test cases to show what was failing before?
Collaborator
Author
|
Done for general type coercions. However can't test the exact case I wanted to fix since I can't define enums in Jinjava right now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's say you have a string
TESTand an enum TEST. Under the usual==operation the expression evaluater will convert the enum to a string for comparison usingBooleanOperations. This mimics this behavior inequaltoexpression test so there is no distinction between them.