Add more sequence expression tests.#175
Merged
Merged
Conversation
Collaborator
Author
|
We have no unit tests right now for these expression tests. Maybe I should just bite the bullet and write all of them? @boulter ? |
Collaborator
Author
|
Ok @boulter tests are added for these new expression tests. |
boulter
reviewed
Feb 8, 2018
|
|
||
| @Override | ||
| public String getName() { | ||
| return "containingall"; |
Collaborator
Author
There was a problem hiding this comment.
It doesn't make grammatical sense. The syntax is if val is expTest val2. So that would be if val is containsall val2.
Collaborator
Author
There was a problem hiding this comment.
Whereas is containing, is containingall, and is within are the best verbs I have thought of.
Collaborator
Author
There was a problem hiding this comment.
Or we could reserve the keyword does and do if val1 does contain val2 :)
Collaborator
Author
There was a problem hiding this comment.
But that seems like overkill.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now it is difficult to use
selectattrorif val isfor set functions. This adds three new expression tests:containing,containingall, andwithin.containing: if the sequence contains an element.if [1, 2, 3] is containing 2).containingall, if the sequence contains all elements of another sequence.if [1, 2, 3] is containingall [1, 2].within: if a value is in a sequence of elements.if 1 is within [1, 2, 3]).