Skip to content

Reduce example output for getstatus's doctest#91

Merged
dgarciabriseno merged 2 commits into
Helioviewer-Project:mainfrom
dgarciabriseno:skip-getstatus
Jan 30, 2023
Merged

Reduce example output for getstatus's doctest#91
dgarciabriseno merged 2 commits into
Helioviewer-Project:mainfrom
dgarciabriseno:skip-getstatus

Conversation

@dgarciabriseno

Copy link
Copy Markdown
Collaborator

It breaks whenever the ordering of keys in the JSON object changes.

It breaks due to ordering issues.
Comment thread hvpy/facade.py Outdated
>>> from hvpy import getStatus
>>> getStatus()
{'AIA': ..., 'COSMO': ..., 'HMI': ..., 'LASCO': ..., 'SECCHI': ..., 'SWAP': ..., 'XRT': ...}
>>> getStatus() # doctest: +SKIP

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its a shame it keeps changing, I wonder if we want to sort the return in future?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even sorted it would break again when a new source is added.
Does this support partial objects? Could I have it check:

{'AIA': ..., ...}

That would verify that at least something is returned.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should work.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it worked a treat. Lets hope no one launches ABA soon.

@codecov-commenter

codecov-commenter commented Jan 30, 2023

Copy link
Copy Markdown

Codecov Report

Base: 98.93% // Head: 98.93% // No change to project coverage 👍

Coverage data is based on head (9132fcc) compared to base (08963df).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #91   +/-   ##
=======================================
  Coverage   98.93%   98.93%           
=======================================
  Files          38       38           
  Lines         941      941           
=======================================
  Hits          931      931           
  Misses         10       10           
Impacted Files Coverage Δ
hvpy/facade.py 97.18% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dgarciabriseno dgarciabriseno changed the title Skip getstatus() doctest. Reduce example output for getstatus's doctest Jan 30, 2023
@dgarciabriseno
dgarciabriseno merged commit 8e2a202 into Helioviewer-Project:main Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants