Update suvi IDs to the ones implemented in helioviewer#86
Merged
Conversation
nabobalis
approved these changes
Dec 7, 2022
Collaborator
Author
|
@nabobalis Can you help me figure out what's going on here: https://github.com/Helioviewer-Project/python-api/actions/runs/3641000254/jobs/6164598184 ? |
Member
|
That's pretty new to me, I wonder if its an effect of the new version of tox (4.0) that came out yesterday. I will see if I can debug this locally. |
Member
|
#87 I think fixes the CI, so you will want to review it, merge it and rebase/merge in main here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While hvpy was under development suvi images were in beta with different source IDs.
Now SUVI has been enabled on helioviewer with different IDs.
The new IDs were chosen to align with RoB's Helioviewer mirror. (The only other mirror I know supporting SUVI).
The IDs in the main helioviewer repository will be set to use these IDs for any new mirrors that may come up.