Skip to content

Adds createMovie function to generate movie #73

Merged
nabobalis merged 16 commits into
Helioviewer-Project:mainfrom
akash5100:create_movies
Sep 6, 2022
Merged

Adds createMovie function to generate movie #73
nabobalis merged 16 commits into
Helioviewer-Project:mainfrom
akash5100:create_movies

Conversation

@akash5100

Copy link
Copy Markdown
Collaborator

@akash5100 akash5100 self-assigned this Sep 2, 2022
@codecov-commenter

codecov-commenter commented Sep 3, 2022

Copy link
Copy Markdown

Codecov Report

Base: 99.53% // Head: 99.41% // Decreases project coverage by -0.12% ⚠️

Coverage data is based on head (ceb22c8) compared to base (ccc80c3).
Patch coverage: 97.22% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
- Coverage   99.53%   99.41%   -0.13%     
==========================================
  Files          24       25       +1     
  Lines         647      682      +35     
==========================================
+ Hits          644      678      +34     
- Misses          3        4       +1     
Impacted Files Coverage Δ
hvpy/helpers.py 97.14% <97.14%> (ø)
hvpy/utils.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Comment thread hvpy/helper.py Outdated
Comment thread hvpy/helper.py Outdated
Comment thread hvpy/helper.py Outdated
Comment thread hvpy/helper.py Outdated
Comment thread hvpy/helper.py Outdated
Comment thread hvpy/helper.py
Comment thread hvpy/helper.py Outdated
Comment thread hvpy/helper.py Outdated
Comment thread hvpy/helper.py Outdated
@nabobalis

Copy link
Copy Markdown
Member

2022-08-20T11:42:06.641586_2022-08-20T11:47:06.641586.mp4 is also too verbose of a filename. We need to work out something better.

@akash5100

Copy link
Copy Markdown
Collaborator Author

2022-08-20T11:42:06.641586_2022-08-20T11:47:06.641586.mp4 is also too verbose of a filename. We need to work out something better.

Is only the date reasonable? eg: 2022-08-20_2022-08-21.mp4

@nabobalis

Copy link
Copy Markdown
Member

2022-08-20T11:42:06.641586_2022-08-20T11:47:06.641586.mp4 is also too verbose of a filename. We need to work out something better.

Is only the date reasonable? eg: 2022-08-20_2022-08-21.mp4

I think there needs to be more information.

Comment thread hvpy/helper.py
Comment thread hvpy/helper.py Outdated
@Helioviewer-Project Helioviewer-Project deleted a comment from akash5100 Sep 5, 2022
@Helioviewer-Project Helioviewer-Project deleted a comment from akash5100 Sep 5, 2022
Comment thread hvpy/helper.py
@nabobalis

Copy link
Copy Markdown
Member

So in theory the screenshot version will look like this PR.

Comment thread hvpy/helper.py Outdated
Comment thread hvpy/helper.py Outdated
Comment thread hvpy/helper.py Outdated
Comment thread hvpy/helpers.py Outdated
Comment thread hvpy/helpers.py
@nabobalis
nabobalis merged commit d1b872a into Helioviewer-Project:main Sep 6, 2022
@akash5100
akash5100 deleted the create_movies branch September 7, 2022 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create function for creating a movie

4 participants