Update 6.md#8
Merged
Merged
Conversation
Not entirely sure what level of specificity you are going for, but as someone typing it in myself as I was following along, found there to be a few things missing in the deltas that took a bit of investigation.
lorensr
approved these changes
Jun 17, 2018
lorensr
left a comment
lorensr
left a comment
Member
There was a problem hiding this comment.
Thanks Justin—we definitely appreciate PRs with gaps in code snippets. While I tried to not repeat imports, I do want them included the first time they're needed in a file!
Will merge once we have a CLA set up
Contributor
Author
|
Sounds great, keep up the good work on the book! |
Member
|
@jrnt30 got the contributor agreement! Would you mind please signing? https://cla-assistant.io/GraphQLGuide/book?pullRequest=8 |
Contributor
Author
|
All done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not entirely sure what level of specificity you are going for, but as someone typing it in myself as I was following along, found there to be a few things missing in the deltas that took a bit of investigation.