docs(agenteye): clarify SDK payload serialization#572
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Custom Fields documentation and changelog explain that structured event payloads remain JSON where possible, while unsupported values are converted to strings so events continue recording. ChangesPython SDK documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/agenteye/python-sdk.mdx`:
- Around line 415-416: Rephrase the sentence following “Keep payloads as
structured JSON” to use grammatically clear wording for values that JSON does
not natively support, while preserving the existing examples and meaning about
converting them to strings.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 3eafccbb-6e10-47e2-b9d0-f7656cf06a78
📒 Files selected for processing (1)
docs/agenteye/python-sdk.mdx
Why this documentation is needed
The companion AgentEye audit reproduced a data-loss failure in the Python SDK: values outside JSON native types were serialized on the background writer thread, where one datetime-like value could terminate recording for the process after the application call had already returned. The SDK fix now preserves recording by converting unsupported leaves to strings and retaining failed batches for retry.
The public SDK page must state the observable contract customers can rely on without exposing internal architecture: structured JSON remains queryable as structured data, while unsupported leaves are safely represented as strings.
What changes
Scope
This PR contains public contract wording only. Implementation and operational details remain in the signed-customer enterprise documentation in FailproofAI/agenteye#418.
Validation
Summary by CodeRabbit