[docs/agenteye] Add AgentEye product documentation#507
Conversation
📝 WalkthroughWalkthroughAgentEye documentation is expanded across onboarding, deployment, SDK and collector usage, CLI and assistant interfaces, permissions, evaluations, alerts, audits, tenant management, health monitoring, and troubleshooting. Navigation and translation tooling now support AgentEye as a product. ChangesAgentEye documentation
Estimated code review effort: 5 (Critical) | ~120 minutes Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches📝 Generate docstrings
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🔍 Automated code review started — analyzing [{"additions":48,"deletions":0,"path":"docs/agenteye/evaluations.mdx"},{"additions":60,"deletions":0,"path":"docs/agenteye/instrumentation.mdx"},{"additions":32,"deletions":0,"path":"docs/agenteye/overview.mdx"},{"additions":31,"deletions":1,"path":"docs/docs.json"}] files, +171/-1... ⏱️ This may take a few minutes. Results will be posted here when complete. |
|
⏳ [review in progress] Analyzing the |
|
✅ Build & verification complete — reproduced the CI
|
🔍 Automated Code Review📋 Executive SummaryThis PR adds AgentEye as a second Mintlify product (introducing a top-level product switcher) and three English docs pages ( 📊 Change Architecturegraph TD
DJ["docs.json navigation<br/>languages ➜ products[]"]
P0["Product: FailproofAI<br/>languages: en + 14"]
P1["Product: AgentEye<br/>tabs: English only"]
OV["new: agenteye/overview.mdx"]
IN["new: agenteye/instrumentation.mdx"]
EV["new: agenteye/evaluations.mdx"]
TV["translate:validate<br/>reads nav.languages"]
GE["getEnglishMdxPages()<br/>walks docs/**"]
DJ --> P0
DJ --> P1
P1 --> OV
P1 --> IN
P1 --> EV
DJ -.->|"top-level nav.languages gone<br/>➜ 0 pages checked"| TV
OV -.->|"auto-translated ➜ orphaned<br/>docs/<lang>/agenteye/*"| GE
IN -.-> GE
EV -.-> GE
style DJ fill:#FFD700
style P1 fill:#90EE90
style OV fill:#90EE90
style IN fill:#90EE90
style EV fill:#90EE90
style TV fill:#FFB6C1
style GE fill:#FFB6C1
Legend: 🟢 New · 🟡 Restructured (breaking-risk) · 🔴 Ripple effect / regression 🔴 Breaking Changes✅ No breaking change to the rendered docs or CI.
|
hermes-exosphere
left a comment
hermes-exosphere
left a comment
There was a problem hiding this comment.
🔴 Changes requested. The docs are well-written and the CI docs job is green locally (mintlify validate passes, 303 MDX pages parse, 275 nav refs resolve). However, the navigation.languages → navigation.products[] restructure leaves the translation pipeline (scripts/translate-docs/) inconsistent:
translate:validatenow validates 0 pages — it reads the old top-levelnavigation.languages(cli.ts:90) that this PR moved underproducts[].- The new English-only AgentEye pages will be auto-translated into orphaned localized files (
docs/<lang>/agenteye/…) on the next merge tomain(getEnglishMdxPages()isn't product-aware), at real LLM/proxy cost.
See the 2 inline comments + summary comment for root cause and fixes. Please address both (or defer explicitly with a tracking issue) — neither requires changing the docs content. Clean docs otherwise. 👍
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
🧹 Nitpick comments (1)
docs/agenteye/alerts.mdx (1)
92-124: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winTwo unrelated "M of N" mechanisms share overlapping terminology.
eval_compound'scombinator: { "at_least": N }(lines 98-102) combines multiple score conditions within a single evaluation cycle, while the separate "Compound logic (M of N)"eval_window/min_breachesknobs (lines 158-163) debounce breaches across evaluation cycles over time, for any trigger type. Both are called "compound"/"M of N" with no cross-reference between them, which risks readers conflating the two.✏️ Suggested clarifying cross-reference
## Compound logic (M of N) +> Not to be confused with `eval_compound`'s `combinator`, which combines multiple score conditions *within* a single evaluation. The knobs below debounce breaches *across* evaluation cycles, for any trigger type. + Every alert has two integer knobs in addition to the trigger:Also applies to: 156-164
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/agenteye/alerts.mdx` around lines 92 - 124, Clarify the distinction between eval_compound’s combinator { "at_least": N }, which combines conditions within one evaluation cycle, and eval_window’s min_breaches compound logic, which counts breaches across cycles over time. Add cross-references in both the eval_compound section near combinator and the Compound logic (M of N) section near min_breaches, without changing the documented behavior.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/agenteye/audits.mdx`:
- Around line 59-65: Update the triage action table near the existing
acknowledge, resolve, mute/dismiss, and reopen rows to add the callable assign
action. Describe what assigning a finding does, including its target operator or
UI surface, consistent with the documented API behavior accepted by the action
endpoint.
In `@docs/agenteye/cli-recipes.mdx`:
- Around line 124-131: Update the “Triage an incident non-interactively”
recipe’s incidents assign command to use the same second positional assignee
argument documented by the CLI reference, replacing the --assignee option while
preserving the surrounding workflow.
In `@docs/agenteye/deployment.mdx`:
- Around line 113-126: Update the standalone docker run example to pass the
required CLICKHOUSE_URL environment variable alongside DATABASE_URL and
ADMIN_KEY. Also revise the Compose stack description to mention all bundled
services: Postgres, ClickHouse, Redis, the server, and the dashboard.
In `@docs/agenteye/getting-started.mdx`:
- Around line 58-90: Update the “Set your secrets” section so Step 2 exports
ADMIN_KEY in the reader’s current shell after creating the .env file, allowing
the Step 3 curl command to resolve its Authorization header. Keep the existing
.env values and compose workflow unchanged.
In `@docs/agenteye/managed-deployment.mdx`:
- Line 15: Update the link texts in docs/agenteye/managed-deployment.mdx at
lines 15, 104, 127, and 128 to use descriptive titles: GitHub Token Setup,
Assistant, Evaluation Suite, Collector Installation, and Python SDK
respectively, while preserving the existing link destinations.
---
Nitpick comments:
In `@docs/agenteye/alerts.mdx`:
- Around line 92-124: Clarify the distinction between eval_compound’s combinator
{ "at_least": N }, which combines conditions within one evaluation cycle, and
eval_window’s min_breaches compound logic, which counts breaches across cycles
over time. Add cross-references in both the eval_compound section near
combinator and the Compound logic (M of N) section near min_breaches, without
changing the documented behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: a6b11efd-9dac-45c5-a2fe-d6cf2c67bdff
⛔ Files ignored due to path filters (17)
docs/agenteye/images/alert-new.pngis excluded by!**/*.pngdocs/agenteye/images/alerts.pngis excluded by!**/*.pngdocs/agenteye/images/api-keys.pngis excluded by!**/*.pngdocs/agenteye/images/dashboard-fleet.pngis excluded by!**/*.pngdocs/agenteye/images/dashboard-quality.pngis excluded by!**/*.pngdocs/agenteye/images/errors.pngis excluded by!**/*.pngdocs/agenteye/images/events-stream.pngis excluded by!**/*.pngdocs/agenteye/images/incident-detail.pngis excluded by!**/*.pngdocs/agenteye/images/incidents.pngis excluded by!**/*.pngdocs/agenteye/images/login.pngis excluded by!**/*.pngdocs/agenteye/images/models.pngis excluded by!**/*.pngdocs/agenteye/images/queries.pngis excluded by!**/*.pngdocs/agenteye/images/query-lab.pngis excluded by!**/*.pngdocs/agenteye/images/session-detail.pngis excluded by!**/*.pngdocs/agenteye/images/sessions-list.pngis excluded by!**/*.pngdocs/agenteye/images/settings.pngis excluded by!**/*.pngdocs/agenteye/images/users.pngis excluded by!**/*.png
📒 Files selected for processing (21)
docs/agenteye/alerts.mdxdocs/agenteye/api-keys.mdxdocs/agenteye/assistant.mdxdocs/agenteye/audits.mdxdocs/agenteye/cli-recipes.mdxdocs/agenteye/cli-skill.mdxdocs/agenteye/cli.mdxdocs/agenteye/collector-installation.mdxdocs/agenteye/collector-migration.mdxdocs/agenteye/deployment.mdxdocs/agenteye/evaluation-suite.mdxdocs/agenteye/getting-started.mdxdocs/agenteye/github-token.mdxdocs/agenteye/health-monitoring.mdxdocs/agenteye/kubernetes-deployment.mdxdocs/agenteye/managed-deployment.mdxdocs/agenteye/python-sdk.mdxdocs/agenteye/single-pod-deployment.mdxdocs/agenteye/tenant-management.mdxdocs/agenteye/troubleshooting.mdxdocs/docs.json
|
🔍 Automated code review started — analyzing [{"additions":9,"deletions":0,"path":"tests/scripts/translate-docs/mdx-translator.test.ts"},{"additions":49,"deletions":8,"path":"tests/scripts/translate-docs/mintlify-nav.test.ts"},{"additions":312,"deletions":0,"path":"docs/agenteye/alerts.mdx"},{"additions":255,"deletions":0,"path":"docs/agenteye/api-keys.mdx"},{"additions":206,"deletions":0,"path":"docs/agenteye/assistant.mdx"},{"additions":106,"deletions":0,"path":"docs/agenteye/audits.mdx"},{"additions":170,"deletions":0,"path":"docs/agenteye/cli-recipes.mdx"},{"additions":95,"deletions":0,"path":"docs/agenteye/cli-skill.mdx"},{"additions":292,"deletions":0,"path":"docs/agenteye/cli.mdx"},{"additions":401,"deletions":0,"path":"docs/agenteye/collector-installation.mdx"},{"additions":169,"deletions":0,"path":"docs/agenteye/collector-migration.mdx"},{"additions":425,"deletions":0,"path":"docs/agenteye/deployment.mdx"},{"additions":465,"deletions":0,"path":"docs/agenteye/evaluation-suite.mdx"},{"additions":229,"deletions":0,"path":"docs/agenteye/getting-started.mdx"},{"additions":132,"deletions":0,"path":"docs/agenteye/github-token.mdx"},{"additions":125,"deletions":0,"path":"docs/agenteye/health-monitoring.mdx"},{"additions":0,"deletions":0,"path":"docs/agenteye/images/alert-new.png"},{"additions":0,"deletions":0,"path":"docs/agenteye/images/alerts.png"},{"additions":0,"deletions":0,"path":"docs/agenteye/images/api-keys.png"},{"additions":0,"deletions":0,"path":"docs/agenteye/images/dashboard-fleet.png"},{"additions":0,"deletions":0,"path":"docs/agenteye/images/dashboard-quality.png"},{"additions":0,"deletions":0,"path":"docs/agenteye/images/errors.png"},{"additions":0,"deletions":0,"path":"docs/agenteye/images/events-stream.png"},{"additions":0,"deletions":0,"path":"docs/agenteye/images/incident-detail.png"},{"additions":0,"deletions":0,"path":"docs/agenteye/images/incidents.png"},{"additions":0,"deletions":0,"path":"docs/agenteye/images/login.png"},{"additions":0,"deletions":0,"path":"docs/agenteye/images/models.png"},{"additions":0,"deletions":0,"path":"docs/agenteye/images/queries.png"},{"additions":0,"deletions":0,"path":"docs/agenteye/images/query-lab.png"},{"additions":0,"deletions":0,"path":"docs/agenteye/images/session-detail.png"},{"additions":0,"deletions":0,"path":"docs/agenteye/images/sessions-list.png"},{"additions":0,"deletions":0,"path":"docs/agenteye/images/settings.png"},{"additions":0,"deletions":0,"path":"docs/agenteye/images/users.png"},{"additions":1410,"deletions":0,"path":"docs/agenteye/kubernetes-deployment.mdx"},{"additions":171,"deletions":0,"path":"docs/agenteye/managed-deployment.mdx"},{"additions":387,"deletions":0,"path":"docs/agenteye/python-sdk.mdx"},{"additions":484,"deletions":0,"path":"docs/agenteye/single-pod-deployment.mdx"},{"additions":167,"deletions":0,"path":"docs/agenteye/tenant-management.mdx"},{"additions":693,"deletions":0,"path":"docs/agenteye/troubleshooting.mdx"},{"additions":798,"deletions":844,"path":"docs/docs.json"},{"additions":73,"deletions":52,"path":"scripts/translate-docs/cli.ts"},{"additions":53,"deletions":32,"path":"scripts/translate-docs/mdx-translator.ts"},{"additions":77,"deletions":8,"path":"scripts/translate-docs/mintlify-nav.ts"}] files, +7753/-944... ⏱️ This may take a few minutes. Results will be posted here when complete. |
|
✅ Re-review build & verification complete — reproduced the full CI-equivalent suite locally on
Verification of the three prior findings (all confirmed fixed in
|
|
✅ Resolved 3 previously-reported issues — all confirmed fixed in
The 5 open |
🔍 Automated Code Review (re-review)📋 Executive SummaryThis re-review covers the two new commits since the last review on 📊 Change Architecturegraph TD
DJ["docs.json<br/>navigation.products[]"]
P0["Product: FailproofAI<br/>languages: en + 14"]
P1["Product: AgentEye<br/>tabs: English-only · 20 pages"]
GNR["NEW getNavigationPageReferences()<br/>recursive nav walker"]
UDJ["updateDocsJson()<br/>product-aware branch"]
GEP["getEnglishMdxPages()<br/>now skips agenteye/"]
TV["translate:validate<br/>0 ➜ 292 refs ✅"]
WF["translate-docs.yml<br/>no orphaned agenteye/* ✅"]
TST["NEW regression tests<br/>39 passing"]
DJ --> P0
DJ --> P1
GNR -->|"walks products/languages/tabs/groups"| TV
UDJ -->|"regenerates FailproofAI langs,<br/>leaves AgentEye untouched"| DJ
GEP -->|"excludes English-only product"| WF
TST -.->|"pins"| GNR
TST -.-> GEP
style P1 fill:#90EE90
style GNR fill:#90EE90
style GEP fill:#90EE90
style UDJ fill:#87CEEB
style TST fill:#90EE90
style TV fill:#90EE90
style WF fill:#90EE90
style DJ fill:#FFD700
Legend: 🟢 New / fixed · 🔵 Modified · 🟡 Restructured 🔴 Breaking Changes✅ No breaking changes.
|
hermes-exosphere
left a comment
hermes-exosphere
left a comment
There was a problem hiding this comment.
✅ Re-review: APPROVED WITH SUGGESTIONS. All three findings from the previous CHANGES REQUESTED review are genuinely fixed in b0c6f7a (verified locally: translate:validate 0→292 refs, agenteye/ excluded from auto-translation, docs.json prettier-clean) and now covered by 39 passing regression tests. Full CI-equivalent suite is green — lint (0 errors), tsc (0 errors), 1950 unit tests, mintlify validate, validate:mdx (320 pages). Resolved the 3 prior threads. The 5 open CodeRabbit items are valid but non-blocking doc-accuracy nits on upstream-synced content (left for author/maintainer) — see summary comment for details and status.
Fix five doc-accuracy issues flagged on the AgentEye enterprise guides: - getting-started: export ADMIN_KEY after writing the .env file so Step 3's curl Authorization header resolves the token instead of sending an empty bearer. - deployment: add the required CLICKHOUSE_URL to the standalone docker run example (the server refuses to boot without ClickHouse) and list ClickHouse + Redis in the Docker Compose service summary. - cli-recipes: align the incidents assign recipe with the positional assignee syntax documented in cli.mdx (drop the non-existent --assignee flag). - audits: document the assign triage action the status endpoint accepts. - managed-deployment: use descriptive link texts (GitHub Token Setup, Assistant, Evaluation Suite, Collector Installation, Python SDK) instead of internal enterprise-docs/*.md paths; destinations unchanged. Also add the missing CHANGELOG entry for this PR. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
🔧 Addressed all 5 CodeRabbit findings in
Verified after the fix:
|
|
🟢 Final status — all clear.
Verdict stands: ✅ APPROVED. The prior blocking regressions are fixed and tested, and every open bot finding is now addressed. Remaining recommendation (non-blocking): mirror the five doc fixes upstream in FailproofAI/agenteye#388 so the next sync doesn't reintroduce them. |
|
🔍 Automated code review started — analyzing [{"additions":12,"deletions":0,"path":".github/workflows/translate-docs.yml"},{"additions":3,"deletions":0,"path":"CHANGELOG.md"},{"additions":14,"deletions":0,"path":"tests/scripts/translate-docs/mdx-translator.test.ts"},{"additions":86,"deletions":8,"path":"tests/scripts/translate-docs/mintlify-nav.test.ts"},{"additions":309,"deletions":0,"path":"docs/agenteye/alerts.mdx"},{"additions":255,"deletions":0,"path":"docs/agenteye/api-keys.mdx"},{"additions":206,"deletions":0,"path":"docs/agenteye/assistant.mdx"},{"additions":107,"deletions":0,"path":"docs/agenteye/audits.mdx"},{"additions":170,"deletions":0,"path":"docs/agenteye/cli-recipes.mdx"},{"additions":95,"deletions":0,"path":"docs/agenteye/cli-skill.mdx"},{"additions":292,"deletions":0,"path":"docs/agenteye/cli.mdx"},{"additions":401,"deletions":0,"path":"docs/agenteye/collector-installation.mdx"},{"additions":169,"deletions":0,"path":"docs/agenteye/collector-migration.mdx"},{"additions":428,"deletions":0,"path":"docs/agenteye/deployment.mdx"},{"additions":465,"deletions":0,"path":"docs/agenteye/evaluation-suite.mdx"},{"additions":235,"deletions":0,"path":"docs/agenteye/getting-started.mdx"},{"additions":132,"deletions":0,"path":"docs/agenteye/github-token.mdx"},{"additions":125,"deletions":0,"path":"docs/agenteye/health-monitoring.mdx"},{"additions":0,"deletions":0,"path":"docs/agenteye/images/alert-new.png"},{"additions":0,"deletions":0,"path":"docs/agenteye/images/alerts.png"},{"additions":0,"deletions":0,"path":"docs/agenteye/images/api-keys.png"},{"additions":0,"deletions":0,"path":"docs/agenteye/images/dashboard-fleet.png"},{"additions":0,"deletions":0,"path":"docs/agenteye/images/dashboard-quality.png"},{"additions":0,"deletions":0,"path":"docs/agenteye/images/errors.png"},{"additions":0,"deletions":0,"path":"docs/agenteye/images/events-stream.png"},{"additions":0,"deletions":0,"path":"docs/agenteye/images/incident-detail.png"},{"additions":0,"deletions":0,"path":"docs/agenteye/images/incidents.png"},{"additions":0,"deletions":0,"path":"docs/agenteye/images/login.png"},{"additions":0,"deletions":0,"path":"docs/agenteye/images/models.png"},{"additions":0,"deletions":0,"path":"docs/agenteye/images/queries.png"},{"additions":0,"deletions":0,"path":"docs/agenteye/images/query-lab.png"},{"additions":0,"deletions":0,"path":"docs/agenteye/images/session-detail.png"},{"additions":0,"deletions":0,"path":"docs/agenteye/images/sessions-list.png"},{"additions":0,"deletions":0,"path":"docs/agenteye/images/settings.png"},{"additions":0,"deletions":0,"path":"docs/agenteye/images/users.png"},{"additions":1410,"deletions":0,"path":"docs/agenteye/kubernetes-deployment.mdx"},{"additions":171,"deletions":0,"path":"docs/agenteye/managed-deployment.mdx"},{"additions":387,"deletions":0,"path":"docs/agenteye/python-sdk.mdx"},{"additions":484,"deletions":0,"path":"docs/agenteye/single-pod-deployment.mdx"},{"additions":167,"deletions":0,"path":"docs/agenteye/tenant-management.mdx"},{"additions":693,"deletions":0,"path":"docs/agenteye/troubleshooting.mdx"},{"additions":798,"deletions":844,"path":"docs/docs.json"},{"additions":73,"deletions":52,"path":"scripts/translate-docs/cli.ts"},{"additions":51,"deletions":31,"path":"scripts/translate-docs/mdx-translator.ts"},{"additions":86,"deletions":8,"path":"scripts/translate-docs/mintlify-nav.ts"}] files, +7824/-943... ⏱️ This may take a few minutes. Results will be posted here when complete. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/translate-docs/mdx-translator.ts`:
- Around line 103-106: Update shouldPreservePath to detect only malformed
/http:// and /https:// protocol paths, preserving valid internal routes such as
/http-something. Expand the image-extension check to accept query parameters,
fragments, or whitespace—including Markdown link titles—after the extension, and
add or update the corresponding translator test for /http-something.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 42db38fd-1b5a-45fd-9914-471ecd1d3494
📒 Files selected for processing (5)
.github/workflows/translate-docs.yml__tests__/scripts/translate-docs/mdx-translator.test.ts__tests__/scripts/translate-docs/mintlify-nav.test.tsscripts/translate-docs/mdx-translator.tsscripts/translate-docs/mintlify-nav.ts
🚧 Files skipped from review as they are similar to previous changes (3)
- tests/scripts/translate-docs/mdx-translator.test.ts
- tests/scripts/translate-docs/mintlify-nav.test.ts
- scripts/translate-docs/mintlify-nav.ts
🔍 Automated Code Review (re-review — new commits since
|
| Check | Command | Result |
|---|---|---|
| Deps / lockfile | bun install --frozen-lockfile |
✅ 558 pkgs, in sync |
| Full unit suite | bunx vitest run |
✅ 1952 passed (109 files) |
| translate-docs tests | bunx vitest run __tests__/scripts/translate-docs/ |
✅ 74 passed |
| Typecheck | bunx tsc --noEmit |
✅ clean |
| Lint | bun run lint |
✅ 0 errors (5 pre-existing warnings, none in changed files) |
| Nav validation | bun run translate:validate |
✅ All 292 page references valid |
| Behavior (live) | exercise getEnglishMdxPages + localizeProductsNavigation |
✅ 20 AgentEye pages; es pages /es-prefixed; images preserved |
Live behavior evidence (AgentEye localization)
Total English pages discovered: 40
of which AgentEye pages: 20
Localized AgentEye (es) tab label: "Documentación" ← translated
Localized AgentEye (es) group labels:
- "Getting started" ← English (gap)
- "Deployment" ← English (gap)
- "Instrumentation and CLI" ← English (gap)
- "Quality" ← English (gap)
- "Operations" ← English (gap)
Localized AgentEye (es) sample pages: ["es/agenteye/getting-started","es/agenteye/github-token"]
Nav validation output
$ bun scripts/translate-docs/cli.ts --validate
All 292 page references are valid.
🔗 Issue Linkage
No GitHub issue is linked, but the PR body references the upstream source pipeline FailproofAI/agenteye#388. Changes align with that sync and the stated "translate AgentEye" direction.
👥 Human Review Feedback
- @NiveditJain (author): posted confirmations on the three prior
hermes-exospherethreads and the CodeRabbit threads (e.g. "Updated per product direction in 74622a9: AgentEye is now intentionally localized"). All are resolved; no pending human change-requests. → ✅ Acknowledged - @coderabbitai (bot): 5 doc-accuracy findings, all resolved (addressed in
b0c6f7a…ae87559). → ✅ Addressed
All 8 pre-existing review threads are already resolved — nothing to re-open or newly resolve in this pass.
💡 Suggestions
- Extend
NAV_TRANSLATIONSwith AgentEye's group names so localized navs are fully translated (see inline comment). - Consider a
console.warninbuildLanguageNavwhen a tab/group label has no translation entry — turns silent English fallbacks into visible signals. - Optionally parameterize the
--update-navlanguages from thepreparejob output for strict subset-dispatch correctness.
🏆 Verdict
NAV_TRANSLATIONS so the localization is complete.
Automated code review · 2026-07-14 14:13:14 UTC · re-review of 74622a9, 2b38b6e
hermes-exosphere
left a comment
hermes-exosphere
left a comment
There was a problem hiding this comment.
74622a9, 2b38b6e): APPROVED WITH SUGGESTIONS.
The AgentEye-localization change is correct, consistent, and well-tested — all CI-equivalent gates pass locally (1952 unit tests ✅, tsc ✅, lint 0 errors ✅, 292/292 nav refs valid ✅, bun install --frozen-lockfile in sync ✅). Language lists are consistent across the workflow, prepare matrix, and config.ts.
One minor, non-blocking finding (inline on scripts/translate-docs/mintlify-nav.ts:149): AgentEye's localized nav group headings stay in English because its group names aren't in buildLanguageNav's groupNameMap/NAV_TRANSLATIONS. Cosmetic only — links resolve and validation passes. Recommend a quick follow-up to NAV_TRANSLATIONS so the localization is complete. See the summary comment for full evidence.
|
Tip For best results, initiate chat on the files or code changes.
|
hermes-exosphere
left a comment
hermes-exosphere
left a comment
There was a problem hiding this comment.
✅ Approved. Reviewed 3 times across commits — all issues addressed, CI green. See summary comment for remaining non-blocking suggestions.
…nt skill (#567) * docs(agenteye): document the agenteye-evaluator agent skill The evaluator skill was published to the public FailproofAI/skills collection (skills submodule d4930e2) but the docs never mentioned it, so the only way to find it was to browse the skills repo directly. Its sibling agenteye-cli has had a page since #507/#561; this gives the evaluator the same treatment. The page leads with the part that actually matters: the SDK surface is a decorator and two models, so the skill's value is the design loop it runs before any code exists — interview, read real sessions, propose 2-4 dimensions that are computable from the events and discriminating between a good and a bad run. It also carries the one thing a reader must know before letting an agent near it: agenteye-evaluator is NOT on public PyPI and the name is unclaimed, so a bare `pip install agenteye-evaluator` can pull a stranger's package into the service that reads production transcripts. The skill works down an install ladder instead; a bare pip install is the tell that the skill never loaded. Cross-links both directions so the page is reachable from the docs it belongs with: cli-skill (build vs read), evaluations, evaluation-suite. Only the English nav entry is added — the daily translate-docs cron picks up the new source and --update-nav regenerates the 14 localized navs from the English tabs. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018GtpF2uFAcGw83gUTciNUm * docs: changelog entry for the agenteye-evaluator skill page (#567) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018GtpF2uFAcGw83gUTciNUm --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
2 participants
Summary
docs/agenteye-syncas the reusable AgentEye docs branchValidation
docs.jsonparses successfullynpx mint validategit diff --checkSource pipeline: FailproofAI/agenteye#388
Review follow-ups (automated)
This branch now also publishes the full AgentEye enterprise guide set and makes the docs translation pipeline product-aware — recursive nav-reference validation (
getNavigationPageReferences) and English-only product exclusion ingetEnglishMdxPages, both with regression tests. Five CodeRabbit doc-accuracy findings were addressed inae87559: exportADMIN_KEYin getting-started; add the requiredCLICKHOUSE_URLto the standalonedocker run; alignincidents assignsyntax with the CLI reference; document theassigntriage action; use descriptive managed-deployment link texts. CI green; all review threads resolved; CHANGELOG updated.Summary by CodeRabbit