Promote French to a fully supported locale#96336
Conversation
French translations are audited; treat fr like en/es so the preferences language row no longer shows the AI-generated translations disclaimer. Co-authored-by: Cursor <cursoragent@cursor.com>
|
cc @dylanexpensify - removing the "beta badge" from the French locale |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 26f6621860
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| const localeEmojis: LocaleEmojis = { | ||
| en: undefined, | ||
| es: undefined, | ||
| fr: undefined, |
There was a problem hiding this comment.
Add French emoji data before supporting fr
With fr now included in FullySupportedLocale, callers such as the emoji picker and reaction name lookup can pass fr to importEmojiLocale, but that function still imports ./es for every non-English locale. I checked assets/emojis and only en.ts/es.ts exist, so selecting French will populate localeEmojis.fr with Spanish emoji names and keywords, causing the French UI to display/search Spanish emoji labels; add/import a French emoji dataset or keep French beta until it exists.
Useful? React with 👍 / 👎.
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Good for product.
Explanation of Change
Promotes French (
fr) fromBETA_LOCALEStoFULLY_SUPPORTED_LOCALESso it is treated like English and Spanish for locale support checks. This is something we should've done when we completed the professional audit of French translations.When a user selects French, Account Settings → Preferences no longer shows the “translations generated automatically” hint under the Language row. English, Spanish, and French are the three fully supported locales.
Registers
frin the emoji locale map so fully supported locale typing stays consistent (emoji keyword data still loads via the existing non-English import path until a dedicatedfremoji file exists).Fixed Issues
$
PROPOSAL:
Tests
Offline tests
N/A
QA Steps
Same as Tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots
web.mov