Skip to content

feat: add update server ip#714

Merged
Siumauricio merged 8 commits into
Dokploy:canaryfrom
kdurek:feat/server-ip
Nov 18, 2024
Merged

feat: add update server ip#714
Siumauricio merged 8 commits into
Dokploy:canaryfrom
kdurek:feat/server-ip

Conversation

@kdurek

@kdurek kdurek commented Nov 17, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@kdurek kdurek requested a review from Siumauricio as a code owner November 17, 2024 17:20
@Siumauricio

Copy link
Copy Markdown
Contributor

Can you add a icon button here? to fetch the IP using getPublicIpWithFallback function and it will autocomplete the value

so we will have two options

  • Using the icon to automatically fill the IP
  • Specifying a custom IP

image

@Siumauricio

Copy link
Copy Markdown
Contributor

Also I see you are adding translations for PL, can you add also a new item to appareance page to toggle the language?

@kdurek

kdurek commented Nov 17, 2024

Copy link
Copy Markdown
Contributor Author

Of course, good idea!

@kdurek

kdurek commented Nov 17, 2024

Copy link
Copy Markdown
Contributor Author

Oh thought it was already added by someone who added language package :D
But yeah will be pleased to do this!

@kdurek

kdurek commented Nov 17, 2024

Copy link
Copy Markdown
Contributor Author

@Siumauricio both done!

@Siumauricio Siumauricio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Siumauricio Siumauricio merged commit 173110a into Dokploy:canary Nov 18, 2024
@Siumauricio Siumauricio mentioned this pull request Nov 18, 2024
@ahmetonurslmz

Copy link
Copy Markdown

Can you add a icon button here? to fetch the IP using getPublicIpWithFallback function and it will autocomplete the value

so we will have two options

  • Using the icon to automatically fill the IP
  • Specifying a custom IP

image

what a great recommendation - loved that!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants