Fix Python 2 except syntax breaking Python 3 parse#114
Merged
Conversation
Three `except A, B:` clauses were SyntaxErrors under Python 3, introduced by 545d3ab. They broke import/collection of core modules (backend/unifier.py wouldn't parse), failing CI and the whole backend test suite. Parenthesize each exception tuple. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Your pull request is automatically being deployed to Dagster Cloud.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Three Python-2-style
except A, B:clauses areSyntaxErrorunder Python 3, introduced by 545d3ab ("Dedup connectors and cut pipeline compute time"). They break import/collection of core modules (backend/unifier.pywon't parse), failing CI for every branch and the whole backend test suite.Fix
Parenthesize each exception tuple:
backend/unifier.py:151—except USGSRateLimitError, PartialOrNoDataError:→except (USGSRateLimitError, PartialOrNoDataError):backend/persisters/ogc_features.py:139—except TypeError, ValueError:→except (TypeError, ValueError):backend/well_correlation.py:115—except TypeError, ValueError:→except (TypeError, ValueError):Verification
python -m py_compilepasses on all three filespython -c "import backend.unifier"succeeds in the.venvShould merge before #112/#113 so their CI can pass.
🤖 Generated with Claude Code