Add large strain support for pyFANS#141
Merged
IshaanDesai merged 6 commits intoJul 16, 2026
Merged
Conversation
# Conflicts: # pyfans/micro.cpp # pyfans/micro.hpp
Snapex2409
force-pushed
the
pyfans-large-strain
branch
from
May 7, 2026 08:37
a2dccf4 to
9888477
Compare
Member
|
Maybe we also want to unpin the micromanager version in the CI introduced in this PR #138. |
Snapex2409
marked this pull request as ready for review
May 7, 2026 09:09
IshaanDesai
self-requested a review
May 7, 2026 09:17
IshaanDesai
approved these changes
Jul 15, 2026
IshaanDesai
left a comment
IshaanDesai
left a comment
Collaborator
There was a problem hiding this comment.
Okay from my side, just one question. @sanathkeshav there are some minor changes in reader.h and reader.cpp, can you please review?
Member
@IshaanDesai, those look alright. But the test is failing. |
IshaanDesai
merged commit Jul 16, 2026
194cf42
into
DataAnalyticsEngineering:develop
8 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds rudimentary support for large strain computations within pyFANS.
Perhaps the large strain material tangent should only be returned optionally (via compile flags)?
Checklist:
CHANGELOG.md.