chore(deps): bundle update && yarn upgrade and bump node-version in workflows#3601
Open
aaronskiba wants to merge 9 commits into
Open
chore(deps): bundle update && yarn upgrade and bump node-version in workflows#3601aaronskiba wants to merge 9 commits into
bundle update && yarn upgrade and bump node-version in workflows#3601aaronskiba wants to merge 9 commits into
Conversation
Update Devise error message rendering to account for the breaking change introduced in Devise 5. The deprecated `devise_error_messages!` helper was removed, so views must render the `devise/shared/error_messages` partial directly.
Revert the RuboCop autocorrection in ApplicationController that replaced Array#any? with Array#intersect?. The autocorrection was not equivalent because the original code checks whether request.fullpath contains any of the configured paths using String#include?, while Array#intersect? performs an array intersection against matching elements. Keep the original behavior of detecting matching URL substrings when deciding whether to store the previous location.
app/controllers/application_controller.rb: - Refactor the `store_location` path matching logic to use a regular expression instead of iterating over an array of paths. - This preserves the existing behavior of checking whether request.fullpath contains one of the Devise authentication paths while avoiding the Style/ArrayIntersect RuboCop autocorrection, which was not equivalent for String#include? usage. - No functional behavior changes are intended. lib/tasks/upgrade.rake: - Replace manual File.open/File.close handling with File.write in the `upgrade rake task`. - This removes the possibility of file descriptor leaks and satisfies the Style/FileOpen RuboCop cop while keeping the file generation logic unchanged. app/models/plan.rb - Disable Metrics/BlockLength offence within `:for_api_v2` scope
Update all GitHub Actions workflows to Node.js 20 and consolidate version management into a `.node-version` file for consistency across CI and local development. Previously, workflows ran with Node.js 18.20.8, which caused `yarn install` to fail after sass was upgraded to 1.101.1 due to an incompatible engine requirement. - Removed explicit `node-version` from all workflow files - Created .`node-version` file with version 20 - `actions/setup-node` automatically detects and uses `.node-version`
Pin jquery-ui to 1.13.3 to prevent an unintended upgrade to 1.14.2. The jquery-ui 1.14.2 upgrade was introduced as part of running `yarn upgrade`. This version adds a dependency on jQuery 4, resulting in compatibility issues with the application's existing jQuery 3 dependency. The upgrade caused feature specs to fail, including JSON parsing failures when submitting organisation links. Resolved failures: - Plans User creates a new Plan - SuperAdmins Orgs Super admin submits invalid data The latter failed with: JSON::ParserError: unexpected character: 'org' at line 1 column 1
Generated by 🚫 Danger |
aaronskiba
changed the title
bundle update && yarn upgrade
aaronskiba
changed the title
bundle update && yarn upgradebundle update && yarn upgrade and bump node-version in workflows
aaronskiba
force-pushed
the
aaron/chore/bump-deps
branch
from
July 17, 2026 20:56
650ca48 to
9b60f40
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
Execute
bundle updateand resolve breaking changesfix(devise): resolve v5 breaking changes
devise_error_messages!helper was removed, so views must render thedevise/shared/error_messagespartial directly.Address rubocop offences
bundle updatebumpedrubocopfrom1.81.1-->1.88.2Execute
yarn upgradeand resolve breaking changesfix: pin
jquery-uito1.13.3to avoid regression from1.14.2upgradejquery-uito1.13.3to prevent an unintended upgrade to1.14.2.jquery-ui1.14.2upgrade was introduced as part of runningyarn upgrade.This version adds a dependency on
jQuery 4, resulting in compatibility issueswith the application's existing
jQuery 3dependency.submitting organisation links.
yarn upgrade#3600ci: bump node to 20 and add .node-version file
Node.js 20and consolidate version management into a.node-versionfile for consistency across CI and local development.Node.js 18.20.8, which causedyarn installto fail aftersasswas upgraded to1.101.1due to an incompatible engine requirement.