feat(sdk-core): export PrebuildTransactionFeeInfo type#9279
Open
mmcshinsky-bitgo wants to merge 1 commit into
Open
feat(sdk-core): export PrebuildTransactionFeeInfo type#9279mmcshinsky-bitgo wants to merge 1 commit into
mmcshinsky-bitgo wants to merge 1 commit into
Conversation
mmcshinsky-bitgo
force-pushed
the
side/types-prebuild-fee-info
branch
3 times, most recently
from
July 16, 2026 15:52
1813bba to
d78b912
Compare
Export PrebuildTransactionFeeInfo from iWallet.ts, convert PrebuildTransactionResult to a type alias, and reuse the fee shape in TSS unsigned/MPC types and the Express FeeInfo codec. WEB-000
OttoAllmendinger
requested changes
Jul 17, 2026
| /** Fee as string */ | ||
| feeString: t.string, | ||
| }); | ||
| export type FeeInfo = PrebuildTransactionFeeInfo; |
Contributor
There was a problem hiding this comment.
the standard t.TypeOf construction would be more appropriate - from here I have no way to tell if they are in fact equal and will stay equal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PrebuildTransactionFeeInfofromiWallet.tsand convertPrebuildTransactionResultfrominterfacetotype.UnsignedTransactionTss/MPCTx(Required<PrebuildTransactionFeeInfo>) and ExpressFeeInfocodec/type alias.@bitgo/public-types— existing public-typesfeeInfoshapes differ (required fields /fee: string | numberon unsigned tx).Out of scope (different shapes)
iBaseCoinUnsignedTransaction.feeInfo(fee: number | BigNumber)FeeInfo(XRP, TRX, UTXO recovery, go-staking)PrebuildTransactionResultDetails.feeInfo(addspayGoFee,gas*, etc.)Test plan
yarn unit-test --scope @bitgo/sdk-core(or the prebuildTransactionTypes suite)yarn tsc --noEmitinmodules/sdk-coreNo ticket — local side improvement (
WEB-000).