Add support for description field#24
Merged
Merged
Conversation
MaryanneNjeri
commented
Jul 1, 2026
Contributor
- Add support for description field.
- Update to the latest app-configuration-js-sdk.
- Update test to verify support for the description field.
There was a problem hiding this comment.
Pull request overview
This PR adds support for the description field when importing configuration settings, updates the Azure App Configuration SDK dependency, and extends unit tests to validate description propagation.
Changes:
- Plumbs
descriptionthrough KVSet parsing and iterable configuration sources. - Updates unit test fixtures/specs to assert
descriptionis preserved. - Bumps
@azure/app-configurationdependency to a newer version.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| libraries/azure-app-configuration-importer/tests/utlis.ts | Updates mocked ConfigurationSetting fixtures to include description. |
| libraries/azure-app-configuration-importer/tests/sources/kvset.json | Adds description fields to KVSet test source data. |
| libraries/azure-app-configuration-importer/tests/kvSetConfigurationSettingsConverter.spec.ts | Asserts KVSet conversion preserves description. |
| libraries/azure-app-configuration-importer/tests/iterableConfigurationSettingsSource.spec.ts | Asserts iterable source output includes description. |
| libraries/azure-app-configuration-importer/src/settingsImport/iterableConfigurationSettingsSource.ts | Adds description to generated settings emitted by the iterable source. |
| libraries/azure-app-configuration-importer/src/models.ts | Extends KvSetConfigurationItem model with optional description. |
| libraries/azure-app-configuration-importer/src/internal/utils.ts | Updates feature-flag comparison typing used in equality checks. |
| libraries/azure-app-configuration-importer/src/internal/parsers/kvSetConfigurationSettingsConverter.ts | Passes through description from KVSet items into SetConfigurationSettingParam. |
| libraries/azure-app-configuration-importer/package.json | Updates @azure/app-configuration dependency version. |
| common/config/rush/pnpm-lock.yaml | Updates lockfile entries for the new SDK version and transitive deps. |
Files not reviewed (1)
- common/config/rush/pnpm-lock.yaml: Generated file
Comments suppressed due to low confidence (1)
libraries/azure-app-configuration-importer/src/internal/utils.ts:55
isConfigSettingEqualdoes not comparedescription, so a setting whose only change is a description update will be treated as equal and will not be updated on the server. This defeats the new description-field support (updates would be skipped).
valueIsEqual = isFeatureFlagValueEqual(settingA.value as string | MsFeatureFlagValue, settingB.value);
}
return valueIsEqual &&
settingA.contentType == settingB.contentType &&
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ChristineWanjau
approved these changes
Jul 8, 2026
ChristineWanjau
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.