Skip to content

Add support for description field#24

Merged
MaryanneNjeri merged 6 commits into
mainfrom
maryanne/support_description_field
Jul 8, 2026
Merged

Add support for description field#24
MaryanneNjeri merged 6 commits into
mainfrom
maryanne/support_description_field

Conversation

@MaryanneNjeri

Copy link
Copy Markdown
Contributor
  • Add support for description field.
  • Update to the latest app-configuration-js-sdk.
  • Update test to verify support for the description field.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for the description field when importing configuration settings, updates the Azure App Configuration SDK dependency, and extends unit tests to validate description propagation.

Changes:

  • Plumbs description through KVSet parsing and iterable configuration sources.
  • Updates unit test fixtures/specs to assert description is preserved.
  • Bumps @azure/app-configuration dependency to a newer version.

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
libraries/azure-app-configuration-importer/tests/utlis.ts Updates mocked ConfigurationSetting fixtures to include description.
libraries/azure-app-configuration-importer/tests/sources/kvset.json Adds description fields to KVSet test source data.
libraries/azure-app-configuration-importer/tests/kvSetConfigurationSettingsConverter.spec.ts Asserts KVSet conversion preserves description.
libraries/azure-app-configuration-importer/tests/iterableConfigurationSettingsSource.spec.ts Asserts iterable source output includes description.
libraries/azure-app-configuration-importer/src/settingsImport/iterableConfigurationSettingsSource.ts Adds description to generated settings emitted by the iterable source.
libraries/azure-app-configuration-importer/src/models.ts Extends KvSetConfigurationItem model with optional description.
libraries/azure-app-configuration-importer/src/internal/utils.ts Updates feature-flag comparison typing used in equality checks.
libraries/azure-app-configuration-importer/src/internal/parsers/kvSetConfigurationSettingsConverter.ts Passes through description from KVSet items into SetConfigurationSettingParam.
libraries/azure-app-configuration-importer/package.json Updates @azure/app-configuration dependency version.
common/config/rush/pnpm-lock.yaml Updates lockfile entries for the new SDK version and transitive deps.
Files not reviewed (1)
  • common/config/rush/pnpm-lock.yaml: Generated file
Comments suppressed due to low confidence (1)

libraries/azure-app-configuration-importer/src/internal/utils.ts:55

  • isConfigSettingEqual does not compare description, so a setting whose only change is a description update will be treated as equal and will not be updated on the server. This defeats the new description-field support (updates would be skipped).
    valueIsEqual = isFeatureFlagValueEqual(settingA.value as string | MsFeatureFlagValue, settingB.value);
  }

  return valueIsEqual &&
    settingA.contentType == settingB.contentType &&

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread libraries/azure-app-configuration-importer/tests/utlis.ts Outdated
Comment thread libraries/azure-app-configuration-importer/package.json
Comment thread libraries/azure-app-configuration-importer/src/internal/utils.ts
Comment thread libraries/azure-app-configuration-importer/src/internal/utils.ts
Comment thread libraries/azure-app-configuration-importer/tests/utlis.ts Outdated
Comment thread libraries/azure-app-configuration-importer/package.json Outdated
@MaryanneNjeri MaryanneNjeri merged commit 6eaea3b into main Jul 8, 2026
2 checks passed
@MaryanneNjeri MaryanneNjeri deleted the maryanne/support_description_field branch July 8, 2026 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants