fix: use single precision for dtoa with f32#2908
Merged
Merged
Conversation
mattjohnsonpint
marked this pull request as draft
February 6, 2025 17:57
mattjohnsonpint
marked this pull request as ready for review
February 6, 2025 18:36
mattjohnsonpint
marked this pull request as draft
February 6, 2025 18:40
This comment was marked as outdated.
This comment was marked as outdated.
mattjohnsonpint
marked this pull request as ready for review
February 6, 2025 19:32
Contributor
Author
|
Haha, I just read this line in the Kotlin sources for their original implementation: And then it looks like just last week, @skuzmich gave it the 32-bit precision support, for the same reasons. Seems fair to add it back here too! (Thanks @skuzmich!) |
MaxGraey
reviewed
Feb 7, 2025
MaxGraey
reviewed
Feb 7, 2025
MaxGraey
reviewed
Feb 7, 2025
MaxGraey
reviewed
Feb 7, 2025
MaxGraey
reviewed
Feb 7, 2025
MaxGraey
reviewed
Feb 7, 2025
MaxGraey
reviewed
Feb 7, 2025
MaxGraey
reviewed
Feb 7, 2025
Member
|
If @MaxGraey says it looks good, we should merge it. |
CountBleck
reviewed
Feb 7, 2025
MaxGraey
approved these changes
Feb 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2873
Changes proposed in this pull request:
Adjusts
dtoaanddtoa_bufferedto accept eitherf32orf64. Implementation details borrowed from Kotlin.