Preserve toolkit docs on merge failures#1080
Draft
jottakka wants to merge 3 commits into
Draft
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jottakka
marked this pull request as draft
July 17, 2026 03:44
Contributor
Author
|
bugbot run |
|
Current version of PR was reviewed by /review-bugbot on Jul 17, 00:59 GMT-3. It flagged 0 findings. Bugbot on commit |
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
bugbot run |
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 8011b5d. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
pnpm exec tsc --noEmit --project toolkit-docs-generator/tsconfig.jsonpnpm exec vitest run --root toolkit-docs-generatorNote
Medium Risk
Changes docs generation failure semantics and CI exit behavior; incorrect fallback could mask stale docs, but strict mode still aborts on incomplete merges.
Overview
When a toolkit merge fails, the generator now keeps last-known-good JSON in batch output and
index.jsoninstead of dropping that toolkit or writing an empty placeholder.MergeResultgains an optionalerrorfield; failed merges return the previous toolkit when one exists, and incrementalonToolkitCompletestill runs for that fallback.The CLI prints a Failed toolkits section, tracks failures via
mergeFailures(not warning-string heuristics), and sets exit code 1 on merge failures or write errors so CI does not treat a partial run as success. With--require-complete,mergeToolkitEntrythrows instead of returning a soft error result.Error results with no prior output no longer copy custom sections from a missing previous toolkit (empty arrays only).
Reviewed by Cursor Bugbot for commit 8011b5d. Bugbot is set up for automated code reviews on this repo. Configure here.