Skip to content

fix(webapp): return 415 for invalid SSO form content types#4238

Merged
ericallam merged 1 commit into
mainfrom
feature/tri-11981-return-415-for-unsupported-sso-form-requests
Jul 13, 2026
Merged

fix(webapp): return 415 for invalid SSO form content types#4238
ericallam merged 1 commit into
mainfrom
feature/tri-11981-return-415-for-unsupported-sso-form-requests

Conversation

@carderne

Copy link
Copy Markdown
Collaborator

Summary

SSO form submissions with an unsupported content type now receive a 415 response instead of failing while parsing the request body.

@changeset-bot

changeset-bot Bot commented Jul 13, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 9b29027

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

The SSO action now validates the request Content-Type before parsing form data. It accepts URL-encoded and multipart form submissions and returns HTTP 415 for unsupported types. A server-changes entry documents this behavior as a webapp fix.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is on-topic but missing most required template sections, including issue closure, checklist, testing, changelog, and screenshots. Add the required template sections: Closes #issue, checklist items, testing steps, changelog summary, and screenshots or N/A.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly matches the change: returning 415 for unsupported SSO form content types.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/tri-11981-return-415-for-unsupported-sso-form-requests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

coderabbitai[bot]

This comment was marked as resolved.

@carderne carderne marked this pull request as ready for review July 13, 2026 09:41

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@ericallam ericallam merged commit c0f7c80 into main Jul 13, 2026
55 of 57 checks passed
@ericallam ericallam deleted the feature/tri-11981-return-415-for-unsupported-sso-form-requests branch July 13, 2026 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants